Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files are picked up as ember core modules #212

Open
nathancharles opened this issue Jan 10, 2018 · 0 comments · May be fixed by #213
Open

Test files are picked up as ember core modules #212

nathancharles opened this issue Jan 10, 2018 · 0 comments · May be fixed by #213

Comments

@nathancharles
Copy link

nathancharles commented Jan 10, 2018

Currently tests are being picked up by the isEmberCoreModule check, possibly triggering rules, depending on the code in the test.

Given some test for a controller like this, it will be picked up as an ember controller because of the path and trigger the alias-model-in-controller rule.

import { moduleFor, test } from 'ember-qunit';

const somethingThatNeedsToUseExtend = Ember.Object.extend({...});

moduleFor('controller:my-controller', 'Unit | Controller | my controller', {
...

I wll submit a PR, but excluding files with tests in the path from the isEmberCoreModule check would solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant