From 23256a6f51732549b8e5151ea81eaad4504d5a5c Mon Sep 17 00:00:00 2001 From: crbelaus Date: Tue, 10 Sep 2024 16:04:07 +0200 Subject: [PATCH 1/2] Underscore private function name in router Underscored functions are never imported by default. --- lib/error_tracker/web/router.ex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/error_tracker/web/router.ex b/lib/error_tracker/web/router.ex index 7e6c7b0..50753ea 100644 --- a/lib/error_tracker/web/router.ex +++ b/lib/error_tracker/web/router.ex @@ -34,7 +34,7 @@ defmodule ErrorTracker.Web.Router do # paths for navigating through the dashboard. scoped_path = Phoenix.Router.scoped_path(__MODULE__, path) # Generate the session name and session hooks. - {session_name, session_opts} = parse_options(opts, scoped_path) + {session_name, session_opts} = __parse_options__(opts, scoped_path) scope path, alias: false, as: false do import Phoenix.LiveView.Router, only: [live: 4, live_session: 3] @@ -49,7 +49,7 @@ defmodule ErrorTracker.Web.Router do end @doc false - def parse_options(opts, path) do + def __parse_options__(opts, path) do custom_on_mount = Keyword.get(opts, :on_mount, []) session_name = Keyword.get(opts, :as, :error_tracker_dashboard) From ca133da96fbaf36454e30cd36244f8d0d9be1ca5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cristian=20=C3=81lvarez=20Belaustegui?= Date: Tue, 10 Sep 2024 16:57:30 +0200 Subject: [PATCH 2/2] Update lib/error_tracker/web/router.ex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Óscar de Arriba --- lib/error_tracker/web/router.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/error_tracker/web/router.ex b/lib/error_tracker/web/router.ex index 50753ea..58a2b44 100644 --- a/lib/error_tracker/web/router.ex +++ b/lib/error_tracker/web/router.ex @@ -34,7 +34,7 @@ defmodule ErrorTracker.Web.Router do # paths for navigating through the dashboard. scoped_path = Phoenix.Router.scoped_path(__MODULE__, path) # Generate the session name and session hooks. - {session_name, session_opts} = __parse_options__(opts, scoped_path) + {session_name, session_opts} = ErrorTracker.Web.Router.__parse_options__(opts, scoped_path) scope path, alias: false, as: false do import Phoenix.LiveView.Router, only: [live: 4, live_session: 3]