Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router conflict with PhoenixAnalytics #90

Closed
wkirschbaum opened this issue Sep 10, 2024 · 2 comments · Fixed by #91
Closed

Router conflict with PhoenixAnalytics #90

wkirschbaum opened this issue Sep 10, 2024 · 2 comments · Fixed by #91
Labels
bug Something isn't working

Comments

@wkirschbaum
Copy link

The following error pops up when used with phoenix analytics

error: function parse_options/2 imported from both PhoenixAnalytics.Web.Router and ErrorTracker.Web.Router, call is ambiguous

Would it be possible to move the function parse_options/2 to another module and not import it?

lalabuy948/PhoenixAnalytics#2

@crbelaus crbelaus added the bug Something isn't working label Sep 10, 2024
@crbelaus
Copy link
Contributor

Thanks for reporting this @wkirschbaum. The parse_options/2 should be underscored to exclude it from being automatically imported, such like we do for the __session__/2 function`

This should be fixed in #91

@wkirschbaum
Copy link
Author

@crbelaus fantastic thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants