Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enforce code style with Black #237

Open
uniqueg opened this issue May 20, 2024 · 2 comments
Open

ci: enforce code style with Black #237

uniqueg opened this issue May 20, 2024 · 2 comments
Labels
priority: low Low priority type: ci / cd Related to continuous integration / delivery workload: minutes Likely takes minutes to resolve
Milestone
v1.0.0

Comments

@uniqueg
Copy link
Member

uniqueg commented May 20, 2024

Use Black to auto-format code and include check in CI workflow.
@uniqueg uniqueg added priority: low Low priority type: style Related to code style workload: minutes Likely takes minutes to resolve labels May 20, 2024
@uniqueg uniqueg added this to the v1.0.0 milestone May 20, 2024
@uniqueg uniqueg added type: ci / cd Related to continuous integration / delivery and removed type: style Related to code style labels May 20, 2024
@JaeAeich
Copy link

Just a suggestion but I see there are 3 issues for the same, using pylint, black and flake8-docstring would just increase the number of deps. If we are just here to enfoce certain coding style rules why not do it with one dep (ruff), checkout the config in TESK (main branch).

@uniqueg
Copy link
Member Author

uniqueg commented May 21, 2024

Yup, was thinking the same 👍 But they are still three separate issues. Doesn't mean that we can't close them all with the same PR ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Low priority type: ci / cd Related to continuous integration / delivery workload: minutes Likely takes minutes to resolve
Projects
FOCA release
Status: Todo other
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@uniqueg @JaeAeich