Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tapping on user mentions #2021

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Handle tapping on user mentions #2021

merged 1 commit into from
Dec 14, 2023

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Added code to handle tapping on mentions for onLinkClicked callback.
  • Added specific onMentionClicked(Mention) callback.
  • Added Mention.Room and a couple of helper functions to get the room id and alias from Permalink.RoomLink.
  • Make a user mention open the user's profile. Room and @room mentions do nothing for now.

Motivation and context

Closes #1448 .

Screenshots / GIFs

There should be no UI changes.

Tests

  • Open a room.
  • Tap on a user mention pill, see that it opens its profile.
  • Tap on an @room or room/event mention pill, it should do nothing.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner December 14, 2023 07:15
@jmartinesp jmartinesp requested review from bmarty and removed request for a team December 14, 2023 07:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1LfwYd

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (1e86d82) 67.68% compared to head (835d110) 67.67%.
Report is 8 commits behind head on develop.

Files Patch % Lines
...s/impl/timeline/components/TimelineItemEventRow.kt 25.00% 9 Missing ⚠️
...ement/android/libraries/matrix/api/room/Mention.kt 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2021      +/-   ##
===========================================
- Coverage    67.68%   67.67%   -0.01%     
===========================================
  Files         1327     1327              
  Lines        33357    33368      +11     
  Branches      7183     7188       +5     
===========================================
+ Hits         22578    22583       +5     
- Misses        7375     7381       +6     
  Partials      3404     3404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tapping on User mentions work!

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@jmartinesp jmartinesp enabled auto-merge (squash) December 14, 2023 11:25
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@jmartinesp jmartinesp merged commit 2492584 into develop Dec 14, 2023
16 of 18 checks passed
@jmartinesp jmartinesp deleted the feature/jme/1448-handle-tapping-on-user-mentions branch December 14, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mentions: Handle tapping on a user mention
2 participants
@jmartinesp @bmarty