MSC2530 image captions are used as filenames

[frebib]

Steps to reproduce

1. Send an MSC2530 compatible event with a supported client (e.g. Beeper, or use Move attachment preview above the composer, allowing to add captions … #2600) with a pretty lengthy caption, enough to hit the "File name too long" error message. In my case it was sent with mautrix-whatsapp with MSC2530 functionality enabled.
2. Look in the app logs

Outcome

What did you expect?

The body field to not be used as part of the filename, but the filename field instead (as per MSC2530)

What happened instead?

2024-05-20T22:04:26.220575Z ERROR elementx: org.matrix.rustcomponents.sdk.ClientException$Generic: msg=File name too long (os error 36) at path "/data/user/0/io.element.android.x/cache/temp/media/.tmppY5zlJ/These words here are the body field of the m.image event.jpeg"
from an event that looks like

{
  "type": "m.room.message",
  ...
  "content": {
    "body": "These words here are the body field of the m.image event",
    "filename": "image.jpg",
    ...
    "msgtype": "m.image",
  },
  ...
}

The image doesn't show/load in the timeline, and clicking on it gives a "Sorry, an error occurrred" message popup

It's possible that this is a Rust SDK bug, in which case please move this issue

Your phone model

No response

Operating system version

No response

Application version and app store

5d8cc80

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

[frebib]

Hit this again today

2024-09-30T19:37:45.938083Z ERROR elementx: org.matrix.rustcomponents.sdk.ClientException$Generic: msg=File name too long (os error 36) at path "/data/user/0/io.element.android.x/cache/temp/media/.tmp0f8hs5/2992: **UK Coal**\nThe Watership Down rabbits removed an additional 0.1 nanometers constructing their warren, although that was mostly soil. British rabbits have historically mined very little coal; the sole rabbit-run coal plant was shut down in the 1990s."
        at org.matrix.rustcomponents.sdk.FfiConverterTypeClientError.read(SourceFile:26)
        at org.matrix.rustcomponents.sdk.FfiConverterRustBuffer$DefaultImpls.liftFromRustBuffer(SourceFile:13)
        at org.matrix.rustcomponents.sdk.FfiConverterTypeClientError.liftFromRustBuffer(SourceFile:1)
        at org.matrix.rustcomponents.sdk.FfiConverterRustBuffer$DefaultImpls.lift(SourceFile:6)
        at org.matrix.rustcomponents.sdk.ClientException$ErrorHandler.lift(SourceFile:8)
        at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt.access$uniffiCheckCallStatus(SourceFile:123)
        at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt.uniffiRustCallAsync(SourceFile:194)
        at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt$uniffiRustCallAsync$1.invokeSuspend(Unknown Source:17)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:9)
        at kotlinx.coroutines.DispatchedTask.run(SourceFile:113)
        at com.google.android.gms.tasks.zzc.run(SourceFile:49)
        at kotlinx.coroutines.scheduling.TaskImpl.run(SourceFile:3)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:96)
 |