Skip to content

Releases: eic/EICrecon

v1.11.0

05 Mar 00:16
fcd8c84
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • improvement in charge calculation in trackseeding by @Jeet-bhai in #1281
  • Included PCA calculations using a straight-line approximation in truth seeded tracking by @harsimranhs in #1291
  • add raw tracker hits to output collection by @ShujieL in #1301
  • feat: write edm4eic::Tracks in CKFTracking by @wdconinc in #1285
  • Generic template collector factory by @simonge in #1282
  • fit: convert TrackPropagation_factory to JOmniFactory by @wdconinc in #1317
  • Introduce factory to subdivide collection by @simonge in #1251
  • feat: add cmake-format and cmake-lint support and first pass cleanup by @wdconinc in #1147
  • fix: rm unused TrackProjectorConfig by @wdconinc in #1319

🪪 Particle identification

🚿 Calorimetry

  • feat: register DD4hep_service as algorithms::GeoSvc provider by @wdconinc in #1195
  • feat: use logger service that comes with algorithms by @wdconinc in #1197
  • Update BHCal Sector and Layer Fields to Match New Readout by @ruse-traveler in #1240

⏩ Far Forward

⚙️ Infrastructure

  • [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #1295
  • fix(ci): accept failing workflow runs as source of capybara reference by @wdconinc in #1299
  • fix(ci): reduce API requests by specifying workflow name by @wdconinc in #1303
  • fix(ci): store pull_request.head.sha for later use by @wdconinc in #1304
  • fix(ci): accept only completed workflow runs as source of capybara reference by @wdconinc in #1306
  • feat(ci): add last updated timestamp to capybara post by @wdconinc in #1307
  • fix: rm redundant src/tests/track_seeding by @wdconinc in #1316

New Contributors

Full Changelog: v1.10.0...v1.11.0

v1.10.0

09 Feb 17:57
8d28402
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • fix: rm Acts detail header for stable interface by @wdconinc in #1187
  • fix: forward compatibility with Acts-v31 by @wdconinc in #1188
  • Updated track seeding globaltoLocal() conversion by @bschmookler in #1185
  • feat: migrate PhotoMultiplierDigi_factory to JOmniFactory by @wdconinc in #1177
  • fixed Seed charge calculation by @Jeet-bhai in #1213
  • Fix: Small change to phi difference calculation in seed charge determination by @bschmookler in #1214
  • fix: convert TrackParamTruthInit to use DD4hep units by @wdconinc in #1198
  • fix: use track direction in localToGlobal in TrackProjector by @wdconinc in #1242
  • feat: forward support edm4eic version 5 by @wdconinc in #1241
  • fix: explicitly set off-diagonal elements in the covariance matrices by @wdconinc in #1244
  • treewide: cleanup EDM4eic 2.x deprecation, require at least 3.0 by @veprbl in #1256
  • fix: use jacobian to convert bound covariance to free 3d position error by @wdconinc in #1252
  • refactor: update to edm4eic v5.0.0 by @osbornjd in #1278
  • Issue warning if surface not planar in draw surfaces by @rahmans1 in #1274

🪪 Particle identification

  • feat: convert MergeTracks to use algorithms:: interface (not yet omni) by @wdconinc in #1234
  • MergeTracks.h: fix spelling by @veprbl in #1236
  • feat: convert MergeParticleID to use algorithms:: interface by @wdconinc in #1238
  • ParticlesWithPID: add associations from ReconstructedParticles to TrackParameters by @veprbl in #1210
  • src/detectors: s/DigiHit/RawHit/g by @veprbl in #1265

🚿 Calorimetry

  • fix: adopt algorithms:: interface in CalorimeterHitsMerger by @wdconinc in #1182
  • fix: adopt algorithms:: interface in CalorimeterIslandCluster by @wdconinc in #1183
  • fix: adopt algorithms:: interface in CalorimeterHitReco by @wdconinc in #1181
  • fix: rm unused GeoSvc from CalorimeterClusterRecoCoG by @wdconinc in #1194
  • fix: better support for downstream CMake consumers by @wdconinc in #1193
  • fix: convert ImagingClusterReco to algorithms interface by @wdconinc in #1201
  • fix: convert EnergyPositionClusterMerger to algorithms interface by @wdconinc in #1200
  • feat: convert CalorimeterTruthClustering to algorithms interface by @wdconinc in #1199
  • fix: convert ImagingTopoCluster to algorithms interface by @wdconinc in #1202
  • fix: convert TruthEnergyPositionClusterMerger to algorithms interface by @wdconinc in #1208
  • CalorimeterClusterRecoCoG: copy hits references from ProtoCluster by @veprbl in #1224
  • ZDC: LYSO + SiPM-on-tile by @sebouh137 in #1221
  • Fix hit merging and add thresholds for backward HCal by @lkosarz in #1250
  • Update CalorimeterClusterRecoCoGConfig: specify units for default value logWeightBase_Eref by @veprbl in #1266

⚙️ Infrastructure

  • feat: set default CMAKE_BUILD_TYPE in CMakeLists.txt by @wdconinc in #1191
  • feat: install capybara only when not available by @wdconinc in #1110
  • feat: rm print_functions.cmake with non-standard macros by @wdconinc in #1192
  • feat(ci): trigger eicweb container build for benchmarks by @wdconinc in #471
  • linux-eic-shell.yml: don't install Bokeh and PyGitHub via pip by @veprbl in #1230
  • linux-eic-shell.yml: delay posting capybara comment until pages are deployed by @veprbl in #1243
  • linux-eic-shell.yml: fix capybara comment regressions by @veprbl in #1245
  • fix(ci): run regularly on main by @wdconinc in #1253
  • fix: avoid CI warnings by upgrading actions; add dependabot by @wdconinc in #1258
  • fix(ci): don't trigger eic_container in merge queue by @wdconinc in #1233

New Contributors

Full Changelog: v1.9.1...v1.10.0

v1.9.1

24 Dec 16:33
fde1872
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

Full Changelog: v1.9.0...v1.9.1

v1.9.0

08 Dec 22:50
3ad7e59
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

🪪 Particle identification

  • fix: avoid narrowing warning with decltype in MergeParticleID by @wdconinc in #1158
  • feat: migrate ParticlesWithPID_factory to JOmniFactory by @wdconinc in #1178

🚿 Calorimetry

  • Adjust threshold settings in LUMISPECCAL by @dhevang in #1156
  • feat: use algorithms:: interface CalorimeterHitDigi (incl RandomSvc) by @wdconinc in #1148
  • Make sure only one of thresholdFactor & thresholdValue are non-zero by @kkauder in #1099

⚙️ Infrastructure

  • fix: update CMAKE_CXX_STANDARD default to 20, now required by Acts by @wdconinc in #1129
  • fix: link tests with --no-as-needed due to JANA #255 by @wdconinc in #1130
  • feat(ci): produce PR and capybara summary; print to step summary by @wdconinc in #1122
  • algorithms_test/CMakeLists.txt: alternative option detection mechanism by @veprbl in #1132
  • fix: change back to eic-shell nightly by @wdconinc in #1134
  • feat: only run clang eicrecon-{dis,gun}, no more gcc by @wdconinc in #1139
  • fix(ci): install into prefix and upload as tar artifact by @wdconinc in #1125
  • fix(ci): compress install and build artifact with zstd by @wdconinc in #1152
  • fix(ci): run clang-tidy with extra-args -std=c++20 by @wdconinc in #1150
  • fix: set C++std to 20, allow higher; agree with Acts and ROOT by @wdconinc in #1135
  • fix: more generic iwyu command line interface by @wdconinc in #1159
  • fix: install {asan,lsan,tsan,ubsan}.supp with CMake; other CMake cleanup by @wdconinc in #1140
  • fix(ci): test eicmkplugin with EICrecon_ROOT=install/ by @wdconinc in #1164
  • fix(ci): don't upload unused build directory artifacts by @wdconinc in #1123
  • fix: disable bugprone-unchecked-optional-access in .clang-tidy by @wdconinc in #1173

Full Changelog: v1.8.0...v1.9.0

v1.8.1

22 Nov 04:15
Compare
Choose a tag to compare

Full Changelog: v1.8.0...v1.8.1

v1.8.0

17 Nov 21:26
fdc79ac
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • fix: convert DD4hepBfield position units without hardcoding by @wdconinc in #1113
  • feat: upgrade EICrecon to Acts v30 by @wdconinc in #1072

🪪 Particle identification

  • fix: mv id() to getObjectID().index because id() returns ObjectID, not uint_t, in podio v0.17.1 by @wdconinc in #1106

🚿 Calorimetry

  • Updated FEMC threshold and digitization parameters by @kkauder in #1086
  • B0 Ecal threshold by @kkauder in #1101
  • Updated ADC parameters and threshold for HCal (and ECal) inserts by @kkauder in #1104
  • Updated LFHCAL ADC parameters and threshold by @kkauder in #1105
  • fix: rm unused ClusterRecoCoG options by @wdconinc in #1107
  • feat: depend on algorithms; demo interface in CaloClusterRecoCoG by @wdconinc in #1085

⚙️ Infrastructure

  • fix(ci): upload build/ as tar.gz for speedup by @wdconinc in #1112
  • feat: write capybara diff dashboards for PRs to ghpages by @wdconinc in #1114

Full Changelog: v1.7.0...v1.8.0

v1.7.0

07 Nov 03:53
f8e3356
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • fix: use unique_ptr for geometry in DD4hep_service, hand out not_null const pointers by @wdconinc in #1045
  • fix: reenable storing geometryId into TrackPoint surface field by @wdconinc in #1055
  • feat: fill Acts::GeometryIdentfier extra field with DD4hep detector ID by @wdconinc in #1058
  • fix: IWYU pragmas and iwyu.imp fixes by @wdconinc in #1079
  • fix: apply all automatic IWYU suggestions (and 2 fixes by hand) by @wdconinc in #1080
  • fix: use edm4hep vector_utils instead of edm4eic; remove MaterialWiper (prep for Acts v26) by @wdconinc in #1082
  • fix: print magnetic field strength in correct units in ActsGeometryProvider by @wdconinc in #1077
  • treewide: avoid including some internal headers from libstdc++ by @veprbl in #1083
  • replace trackersourcelinker with trackermeasurement by @ShujieL in #1076
  • updated MAPS threshold by @kkauder in #1089

🪪 Particle identification

🚿 Calorimetry

  • treewide: fix spelling by @veprbl in #1042
  • fix: remove adhoc LFHCAL treatment in CalorimeterHitReco by @wdconinc in #1054
  • Remove factories for HcalEndcapP by @veprbl in #1062
  • Adjust reconstruction parameters for Barrel ECal by @mariakzurek in #1078
  • calorimetry_CalorimeterIslandCluster: add test case for adjacencyMatrix code path by @veprbl in #1088
  • Bhcal threshold by @kkauder in #1095
  • Updated EEMC energy threshold and ADC parameters by @kkauder in #1100
  • Updated backward HCAL ADC parameters, removed threshold by @kkauder in #1102
  • Consolidated BEMC thresholds and ADC parameters by @kkauder in #1094

◀️ Backward

⏩ Far Forward

⚙️ Infrastructure

  • feat(ci): release notes definition by @wdconinc in #1041
  • fix(ci): avoid lsan crashes with intercept_tls_get_addr=0 by @wdconinc in #1048
  • feat(ci): test eicmkplugin in CI by @wdconinc in #1031
  • feat: enable ubsan by default in CI, with print_stacktrace=1 and suppressions by @wdconinc in #987
  • [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #1063
  • ci: include-what-you-use, clang-include-fixer by @wdconinc in #755
  • feat: remove epic_brycecanyon as main configuration by @wdconinc in #1038
  • linux-eic-shell.yml: remove last reference to brycecanyon by @veprbl in #1084
  • feat(ci): allow changing jug_xl:nightly as basis for CI jobs by @wdconinc in #1087
  • linux-eic-shell.yml: fix cancel-in-progress by @veprbl in #1097

New Contributors

Full Changelog: v1.6.0...v1.7.0

v1.6.2

10 Oct 17:57
7f212b7
Compare
Choose a tag to compare

What's Changed

  • [Backport v1.6] TrackPropagation_factory: HcalEndcapN_* is not defined anymore, use LFHCAL by @epic-capybara in #1065

Full Changelog: v1.6.1...v1.6.2

v1.6.1

05 Oct 12:49
c57b228
Compare
Choose a tag to compare

What's Changed

  • [v1.6] fix: use subset collection when collecting hits in TrackSeeding (backport of #1050) by @wdconinc in #1051

Full Changelog: v1.6.0...v1.6.1

v1.6.0

03 Oct 19:01
3079a7b
Compare
Choose a tag to compare

What's Changed

🕸️ Tracking

  • fix: unused header cleanup by @wdconinc in #932
  • fix: remove non-POD-ness from OrthogonalTrackSeedingConfig by @wdconinc in #931
  • fix: unused header cleanup by @wdconinc in #934
  • fix: clang-tidy readability-qualified-auto by @wdconinc in #762
  • feat: allow configuring WITH_SHARED_LIBRARY and WITHOUT_PLUGIN by @wdconinc in #940
  • fix: resolve CKFTracking memory leak by @wdconinc in #979
  • fix: address memory leaks in TrackSeeding by @wdconinc in #983
  • fix: address memory leaks in TrackProjector by @wdconinc in #982
  • fix: address memory leaks in IterativeVertexFinder by @wdconinc in #981
  • Revert "CKFTracking: disable RTTI type checks until EICrecon conforms to ODR (#551)" by @veprbl in #1015
  • feat: use our spdlog::logger for Acts logging by @wdconinc in #1012
  • fix: address clang-tidy clang-analyzer warnings by @wdconinc in #1013

🪪 Particle identification

  • fix: Compiler warning in src/tests/algorithms_test/pid_MergeParticleID.cc by @c-dilks in #929
  • fix: disable DRICH radiator and photon vertex cheat code by @wdconinc in #967
  • fix: avoid undefined unsigned integer behavior in pid size checks by @wdconinc in #984
  • Reducing number of track projections inside dRICH by @chchatte92 in #999

🚿 Calorimetry

  • fix: memory leak in CalorimeterClusterRecoCoG by @wdconinc in #974
  • fix: avoid undefined behavior in signed integer 0 bitwise complement by @wdconinc in #985
  • feat: std::optional in cluster reco CoG by @wdconinc in #1000
  • fix: rename JDD4hep_service to DD4hep_service by @wdconinc in #1001
  • fix: move some info logging to debug; remove unneeded fmt::format by @wdconinc in #1007
  • fix: avoid division by zero by not setting weighted position if sum of weights is zero by @wdconinc in #989
  • feat(ci): updates to lsan.supp and require PRs to pass leak checks by @wdconinc in #980

⏩ Far Forward

  • remove unused OffMomentumReconstruction_factory., RomanPotsReconstruction_factory. by @veprbl in #1033
  • fix: rm unused FarForwardParticles by @wdconinc in #1037

⚙️ Infrastructure

  • docs: apk add ttf-freefont for graphviz without boxes by @wdconinc in #926
  • feat(ci): publish GitHub pages site with PR information (no fork) by @wdconinc in #923
  • fix: unset PODIO_JSON_OUTPUT after loading EDM4HEP, EDM4EIC by @wdconinc in #916
  • feat(ci): no cancel-in-progress on main by @wdconinc in #939
  • fix(ci): don't use pre-filled JANA_PLUGIN_PATH with EICrecon plugins by @wdconinc in #942
  • fix: enable rpath on build and install linking by @wdconinc in #938
  • fix(ci): ignore when clang-tidy doesn't produce any fixes by @wdconinc in #893
  • fix: rm doxygen from PRs by @wdconinc in #951
  • pr-backport.yml: add github token by @veprbl in #954
  • fix(ci): use npsim instead of ddsim by @wdconinc in #955
  • feat: new janatop plugin, i.e. janadot without the svg output by @wdconinc in #963
  • linux-eic-shell.yml: enable on maintenance branches by @veprbl in #966
  • ci: pre-commit clang-format (but not CI) by @wdconinc in #753
  • fix(ci): cancel in progress when ref_name != refs/heads/main by @wdconinc in #968
  • fix: use RPATH in build tree, unset LD_LIBRARY_PATH for ctest by @wdconinc in #978
  • feat(ci): correct LD_LIBRARY_PATH prefix and add job step to print ldd *.so by @wdconinc in #986
  • feat(ci): add job to run each benchmark separately by @wdconinc in #848
  • fix(ci): cancel-in-progress false for main by @wdconinc in #998
  • fix: set LD_LIBRARY_PATH for benchmark tests by @wdconinc in #1002
  • fix(ci): run ctest with prefixed LD_LIBRARY_PATH by @wdconinc in #1010
  • fix(ci): avoid API rate exceeding in get-docs-from-open-prs with max-parallel: 4 by @wdconinc in #1006
  • fix(ci): get-docs-from-main for last success workflow, not merely completed by @wdconinc in #995
  • feat: add two-stage test job (digitization/reconstruction); write EventHeader by default by @wdconinc in #1014
  • ci: ccache max size increase and show stats; key name changes by @wdconinc in #774
  • fix: remove all odr violations, and enforce them in ASAN_OPTIONS by @wdconinc in #1023
  • labeler.yml: fix calorimetry tag for EHCAL by @veprbl in #1028
  • [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #1039

New Contributors

Full Changelog: v1.5.0...v1.6.0