Incorrect Makefile recipe dependencies

[kareefardi]

caravel_user_project/openlane/Makefile

Lines 87 to 89 in a01f3f0

	.PHONY: enable-openlane-pdk
	enable-openlane-pdk:
	$(UPRJ_ROOT)/venv/bin/volare enable $(OPEN_PDKS_COMMIT)

This uses venv assuming venv is installed with volare inside. The recipe should have a dependency responsible for installing venv and volare.

[AlberTajuelo]

Hi,

This also affects the GitHub Action (called CI).

Meanwhile, you can fix it in your repository, by adding the following step "Install volare using pip" here are the lines to this file ".github\workflows\user_project_ci.yml":

      - name: Unpack openlane Tarball
        run: |
          sudo mkdir -p ${{ env.OPENLANE_ROOT }}
          sudo chown -R $USER:$USER ${{ env.OPENLANE_ROOT }}
          tar -xf /tmp/openlane.tar -C $OPENLANE_ROOT .

      - name: Install volare using pip
        run: |
          python3 -m venv venv
          source venv/bin/activate
          echo "VIRTUAL ENV:" $VIRTUAL_ENV
          python3 -m pip install --upgrade --no-cache-dir volare

      - name: Harden using Openlane

Also, there is another error that you need to apply this fix:

https://github.com/efabless/caravel_user_project/pull/361/files

With these two fixes, you will have your GitHub action in green (excluding other errors that you could have).

FYI: I notified in Slack to @jeffdi about it because it was added in this PR but without response from him: https://github.com/efabless/caravel_user_project/pull/364/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R279