Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: update redwood branch with upstream #9

Merged
merged 4 commits into from
Jul 29, 2024
Merged

perf: update redwood branch with upstream #9

merged 4 commits into from
Jul 29, 2024

Conversation

bra-i-am
Copy link

@bra-i-am bra-i-am commented Jul 23, 2024 •
edited
Loading

Description

This PR updates the branch redwood.master with upstream

JIRA ISSUE DS-1138

@bra-i-am bra-i-am marked this pull request as ready for review July 24, 2024 00:55
@bra-i-am bra-i-am requested a review from dcoa July 24, 2024 00:55
@dcoa
Copy link
Collaborator

dcoa commented Jul 25, 2024

Test are failing because jest is unable to find axios. We need to add the following line in the jest.config.js

  moduleNameMapper: {
    "^axios$": "axios/dist/axios.js",
  },

Use frontend-app-learning as reference

dcoa
dcoa approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR

@bra-i-am bra-i-am merged commit e0b15d0 into ednx-release/redwood.master Jul 29, 2024
4 checks passed
@bra-i-am bra-i-am deleted the bc/update-redwood branch July 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoa dcoa dcoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bra-i-am @dcoa @arbrandes