Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: RTL Support #152

Open
hamidKMB opened this issue Aug 7, 2024 · 4 comments
Open

feature: RTL Support #152

hamidKMB opened this issue Aug 7, 2024 · 4 comments

Comments

@hamidKMB
Copy link

hamidKMB commented Aug 7, 2024

right now the RTL direction looks like a disaster.
it'll be very great if your team implements this feature

@hamidKMB
Copy link
Author

hamidKMB commented Aug 7, 2024

I'd like to help your team develop this feature, just let me know how I can do this

@neSpecc
Copy link
Contributor

neSpecc commented Aug 7, 2024

Thanks, @hamidKMB . First, let's update your issue with details. Create a list of bad-looking places

@hamidKMB
Copy link
Author

hamidKMB commented Aug 8, 2024

hi @neSpecc .
I hope you doing well.

I created an editorjs playground in codesandbox you can check it if you want to test the below items
playground codesandbox https://codesandbox.io/s/editor-js-forked-r6gtt6?file=/src/editor.js:

** better to open it in new window **

before everything I have to mention that plus the bad-looking parts there are some functionality problems that I've mentioned below

Bad-looking Problems
1- the add-column button integrated with the table
editorjs-add-column-bad-looking

2- the column toolbox selects the wrong column
column-toolbox-bad-looking

3- both LTR and RTL direction shows the sider-quick-compose-btn element like below
sider-quick-compose-btn-bad-looking

Functionality Problems:

  1. the add-column integrated with the table not working at all. even hovering does not apply to it
  2. in the column toolbox doesn't matter user clicks on add a column to the left or right, it always adds a column to the left

===============================================================================

the rows toolbox and button integrated with the table work fine and haven't any problem

@neSpecc
Copy link
Contributor

neSpecc commented Aug 14, 2024

@hamidKMB Seems clear now. You can try to resolve these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants