Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-2759] Onboarding card NTP Experiment #778

Merged
merged 37 commits into from
Sep 26, 2024
Merged

[MOB-2759] Onboarding card NTP Experiment #778

merged 37 commits into from
Sep 26, 2024

Commits on Sep 23, 2024

  1. Create OnboardingCardNTPExperiment

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f603f12 View commit details
    Browse the repository at this point in the history

  2. Create NTPOnboardingCardCell

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bd7565c View commit details
    Browse the repository at this point in the history

  3. Adjust onboarding card UI

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    46241de View commit details
    Browse the repository at this point in the history

  4. Adjust onboarding card constraints

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2ae78df View commit details
    Browse the repository at this point in the history

  5. Using correct translations

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dd11dea View commit details
    Browse the repository at this point in the history

  6. Temporarily point to ios-core feature branch

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5efc188 View commit details
    Browse the repository at this point in the history

  7. Use actual Unleash flag

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a66a32b View commit details
    Browse the repository at this point in the history

  8. Not present onboarding if on experiment

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cec5666 View commit details
    Browse the repository at this point in the history

  9. Remove NTP tooltip if on experiment

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3745974 View commit details
    Browse the repository at this point in the history

  10. Add TODO

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bd958f8 View commit details
    Browse the repository at this point in the history

  11. Add card dismissed user defaults

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9028cdc View commit details
    Browse the repository at this point in the history

  12. Set card dismissed

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7984bcb View commit details
    Browse the repository at this point in the history

  13. Show onboarding on card click

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    491f63b View commit details
    Browse the repository at this point in the history

  14. Add TODO

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dee519f View commit details
    Browse the repository at this point in the history

  15. Change onboarding analytics category when on experiment

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    027e439 View commit details
    Browse the repository at this point in the history

  16. Hide skip button when on experiment

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    83adb87 View commit details
    Browse the repository at this point in the history

  17. Add Analytics tracking

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8b2d65a View commit details
    Browse the repository at this point in the history

  18. Add abb test context to resume and launch.

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9c00e0b View commit details
    Browse the repository at this point in the history

  19. Make MockBrowserCoordinator conform to updated protocol

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7a046e7 View commit details
    Browse the repository at this point in the history

  20. Fix LaunchCoordinator intro tests

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1ffd26c View commit details
    Browse the repository at this point in the history

  21. Fix Ecosia ViewModel and Tooltip tests

    @lucaschifino @d4r1091
    lucaschifino authored and d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    841c19f View commit details
    Browse the repository at this point in the history

  22. UI updates to Onboarding Card Cell. Fixed autoresizing

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5541802 View commit details
    Browse the repository at this point in the history

  23. Fix order of ViewModels

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e34f10b View commit details
    Browse the repository at this point in the history

  24. Update SPM

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0db6958 View commit details
    Browse the repository at this point in the history

  25. Fix button color in onboarding card

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1ae7800 View commit details
    Browse the repository at this point in the history

  26. Remove custom bottom spacing for better UI look

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    50f8f32 View commit details
    Browse the repository at this point in the history

  27. SPM Update

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dec02b4 View commit details
    Browse the repository at this point in the history

  28. Add card prioritization mechanism. 

    Assuming all cards will be shown at the top
    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f57e4af View commit details
    Browse the repository at this point in the history

  29. Revert tests

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ce08512 View commit details
    Browse the repository at this point in the history

  30. Update after rebase

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a0031a3 View commit details
    Browse the repository at this point in the history

  31. Review NTPOnboardingCardCell to add the image

    @d4r1091
    d4r1091 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    808e637 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Made Nudge Cards configurable

    @d4r1091
    d4r1091 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    57b0f5b View commit details
    Browse the repository at this point in the history

  2. Add accessibility to the configurable nudge card action button

    @d4r1091
    d4r1091 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ac9ab67 View commit details
    Browse the repository at this point in the history

  3. Update on image handling

    @d4r1091
    d4r1091 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4c1e311 View commit details
    Browse the repository at this point in the history

  4. SPM Update

    @d4r1091
    d4r1091 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fe78731 View commit details
    Browse the repository at this point in the history

  5. Review structure readding a dedicated view model 

    Better handling of show/hide as well as minor cosmetic fixes
    @d4r1091
    d4r1091 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    18e7623 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Update forceSkipExperiment in skipExperiment

    @d4r1091
    d4r1091 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c501aa5 View commit details
    Browse the repository at this point in the history