You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are doing some ASO (App Store Optimization) and that includes some language tests for release notes as well.
As part of this, we are adding the Mexican language to our release notes automation.
Approach
Transifex seem not to have the option to mirror another language so I ended up adding it and copying the translations from the Spanish one
Included the new folder in our Fastlane's metadata
Other
Took the occasion to fix the release notes Github Workflow (already tested till the "upload to App Store Connect" step)
The merge of both this PR and the Transifex one #766 will trigger the Job which will then fail (?) as there will be no chance to update the metadata for the given version. So will add the Don't Merge label to both.
Ruby Version Update The Ruby version was updated from 2.7 to 3.3.0. Ensure that all dependencies are compatible with this new version to avoid potential runtime issues.
Verify compatibility of the new Ruby version with project dependencies
Ensure that the specified ruby-version is compatible with all the gems used in the project. Ruby 3.3.0 might introduce breaking changes or deprecations that could affect the existing codebase.
-ruby-version: 3.3.0+ruby-version: 3.3.0 # Ensure compatibility with project dependencies
Suggestion importance[1-10]: 8
Why: The suggestion is valid as upgrading to Ruby 3.3.0 could introduce breaking changes or deprecations affecting the project. Ensuring compatibility with all gems is crucial for maintaining the stability of the codebase.
Await the new version drafted (likely 10.1.1) before merging this.
I've already added 10.1.1 to App Store Connect as this will be drafted very soon once bug fixes are merged. I guess we could merge this already then as we'll likely still use the generic release notes 🙂
If we merge this, the workflow to upload the release notes will be triggered as there are changes in the fastlane/metadata folder. The way the script works is to check the version from the Common.xcconfig and tell fastlane to push the release notes against that one. If the version hasn't been updated yet on the Common.xcconfig file, fastlane will try to update the released version.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-2848
Context
We are doing some ASO (App Store Optimization) and that includes some language tests for release notes as well.
As part of this, we are adding the Mexican language to our release notes automation.
Approach
Other
Took the occasion to fix the release notes Github Workflow (already tested till the "upload to App Store Connect" step)
The merge of both this PR and the Transifex one #766 will trigger the Job which will then fail (?) as there will be no chance to update the metadata for the given version. So will add the Don't Merge label to both.