[MOB-2858] Ecosify all ecosia urls

[lucaschifino]

MOB-2858

Context

A bug was reported by BI where we have duplicated user ids for consecutive in-page SERP queries in verticals other than search.

Approach

Using the new method introduced on https://github.com/ecosia/ios-core/pull/158.

Before merging

• Merge core PR first and update package.

Checklist

• I performed some relevant testing on a real device and/or simulator

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 00c06cb)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Logic Change The condition for URL modification has changed from checking if the URL is an Ecosia search query to checking if it should be ecosified. Ensure this new condition correctly encompasses all intended scenarios without unintended side effects.

[d4r1091]

All good my side. Added a small suggestion and will await the Core SPM update to Approve!

[github-actions]

Persistent review updated to latest commit 00c06cb

[github-actions]

PR Code Suggestions ✨

Latest suggestions up to 00c06cb

Category	Suggestion	Score
Maintainability	Simplify conditional logic using a guard statement Consider using a guard statement to simplify the logic and reduce nesting. This makes the code easier to read and maintain. Client/Frontend/Toolbar+URLBar/URLBarView.swift [242-243] -if updatedUrl?.shouldEcosify() ?? false { - updatedUrl = newURL?.ecosified(isIncognitoEnabled: isPrivate) -} +guard updatedUrl?.shouldEcosify() ?? false else { return } +updatedUrl = newURL?.ecosified(isIncognitoEnabled: isPrivate) Suggestion importance[1-10]: 7 Why: The suggestion to use a guard statement improves code readability and maintainability by reducing nesting. However, it slightly changes the logic flow by introducing an early return, which should be carefully considered in the context of the surrounding code.	7

---

Previous suggestions

Suggestions up to commit ed8c6ad

Category	Suggestion	Score
Maintainability	Simplify conditional logic using a guard statement Consider using a guard statement to simplify the logic and reduce nesting. This will make the code easier to read and maintain. Client/Frontend/Toolbar+URLBar/URLBarView.swift [242-243] -if updatedUrl?.shouldEcosify() ?? false { - updatedUrl = newURL?.ecosified(isIncognitoEnabled: isPrivate) -} +guard updatedUrl?.shouldEcosify() ?? false else { return } +updatedUrl = newURL?.ecosified(isIncognitoEnabled: isPrivate) Suggestion importance[1-10]: 7 Why: The suggestion to use a guard statement is valid as it simplifies the conditional logic and reduces nesting, which can improve code readability and maintainability. However, it is not a critical change, so it receives a moderate score. The existing code is correct, and the improved code accurately reflects the suggestion. The context of the code around the suggestion is also considered.	7

[d4r1091]

🚀