Add privacy policy link to send usage data setting #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4r1091
reviewed
Jul 4, 2023
d4r1091
previously approved these changes
Jul 4, 2023
d4r1091
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOB-1838
Context
Follow up to #484.
We have decided to add a learn more "button" redirecting to the privacy policy as consequence to reducing the description. We are using the same approach as FF, adding "Learn More" to the description text and making the whole cell clickable.
Approach
onClickandurlfunctionalities of the settings items to make it clickable."Learn More"translation so that no change in the L10N strings is needed given the upcoming release.