MOB-1852 Udpate macosx xcode ci

[d4r1091]

MOB-1852

Context

Currently, we use Xcode 14.2 to run our unit tests via GH Actions and our deploy pipelines in CircleCI.

In order to benefit from internal API fixes, we shall upgrade to Xcode 14.3.1 as being the latest stable Xcode release.

Approach

Updated both GH and CircleCI to use the latest 14.3.1 Xcode..
Two separate commits to it's easier to revert one of the CIs in case.

Other

• Flag 🎏 : Github MacOS13 is still marked as beta - let's check it out though 😉

🚨Last commit to be reverted. Needed to trigger and hopefully pass tests only

[lucaschifino]

I've noticed some tests are failing and as far as I can tell those seem to also happen locally using Xcode 14.3... I think we have discussed it before and I have not investigated the issue, just thought I would point it 🙂

[d4r1091]

To add further context, it is an issue that Firefox has spotted in similar scenarios.
Though our base version is different. I'll try to gather thoughts and keep you posted.

[ecotopian]

To add further context, it is an issue that Firefox has spotted in similar scenarios.
Though our base version is different. I'll try to gather thoughts and keep you posted.

Wondering if those failing tests really indicate a malfunction of the app with a higher base sdk, or if they are simply false negatives. If it's the latter we can simply deactivate them.

[d4r1091]

I seriously doubt that those tests indicate a clear malfunction based on the SDKs.
As part of this ticket, whilst investigating for the failing ones matching FF codebase, I fixed a crash happening on some tests. I would consider myself happy with deactivating the rest of the tests and monitor the FF Github issues. Happy to take care of that as background job.
If I'll get both your 👍 , I'll deactivate the tests, so far only beloging to TabDisplayManagerTests, wih no further crashes.

[ecotopian]

I seriously doubt that those tests indicate a clear malfunction based on the SDKs.
As part of this ticket, whilst investigating for the failing ones matching FF codebase, I fixed a crash happening on some tests. I would consider myself happy with deactivating the rest of the tests and monitor the FF Github issues. Happy to take care of that as background job.
If I'll get both your 👍 , I'll deactivate the tests, so far only beloging to TabDisplayManagerTests, wih no further crashes.

Fine for me. Let's deactivate the TabDisplayManagerTests and remind ourselves to reactivate them after the next upgrade 🤓

[d4r1091]

Tackled changes @ecotopian @lucaschifino . Tagging for better reach prior to releasing

[ecotopian]

Looks good to me 🚀

[lucaschifino]

LGTM 🙌

[ecotopian]

Tackled changes @ecotopian @lucaschifino . Tagging for better reach prior to releasing

@d4r1091 Are tests passing now? As they haven't run with the latest commit.

[d4r1091]

Yes they do @ecotopian 👍 - ref https://github.com/ecosia/ios-browser/actions/runs/5446548420
The last commit was used to revert the trigger