Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alternative way of implementing Tauchen's method to make_tauchen_ar1() #1409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QingyuanFang
Copy link

By Qingyuan Fang

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@mnwhite
Copy link
Contributor

mnwhite commented Apr 15, 2024

Ruff is mad at two lines with improper whitespace, but otherwise this passes checks. This is functionality that we want, as it addresses true truncated processes, rather than those that are truncated as a matter of approximation.

Should probably add a test using the new feature, and do some sanity checks on its results.

@llorracc
Copy link
Collaborator

@mnwhite perhaps you could explain to what we mean by "a test using the new feature, and a sanity check on the results." Like, presumably, showing that the two methods get very close as the number of gridpoints increases?

@mnwhite
Copy link
Contributor

mnwhite commented Apr 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants