From 729153f3a1b59125bca26b8354895f4180abe700 Mon Sep 17 00:00:00 2001 From: Victor Rubezhny Date: Fri, 7 Jul 2023 13:22:41 +0200 Subject: [PATCH] [tests] Fix NPE in MavenCompletionParticipantDuplicationTest ``` java.lang.NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because "version" is null at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:543) at org.apache.maven.artifact.versioning.ComparableVersion.(ComparableVersion.java:534) at org.apache.maven.artifact.versioning.DefaultArtifactVersion.parseVersion(DefaultArtifactVersion.java:94) at org.apache.maven.artifact.versioning.DefaultArtifactVersion.(DefaultArtifactVersion.java:44) at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipantDuplicationTest$1.compare(MavenCompletionParticipantDuplicationTest.java:116) at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipantDuplicationTest$1.compare(MavenCompletionParticipantDuplicationTest.java:111) ``` --- .../MavenCompletionParticipantDuplicationTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lemminx-maven/src/test/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipantDuplicationTest.java b/lemminx-maven/src/test/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipantDuplicationTest.java index 148fca99..e46d4c5c 100644 --- a/lemminx-maven/src/test/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipantDuplicationTest.java +++ b/lemminx-maven/src/test/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipantDuplicationTest.java @@ -29,7 +29,6 @@ import java.util.stream.Stream; import org.apache.maven.artifact.versioning.DefaultArtifactVersion; -import org.eclipse.lemminx.XMLAssert; import org.eclipse.lemminx.extensions.maven.searcher.RemoteCentralRepositorySearcher; import org.eclipse.lemminx.extensions.maven.utils.MavenLemminxTestsUtils; import org.eclipse.lemminx.services.XMLLanguageService; @@ -112,8 +111,9 @@ public void testDuplicateCompletionVersionOrder() throws IOException, URISyntaxE // Backward order @Override public int compare(CompletionItem o1, CompletionItem o2) { - return new DefaultArtifactVersion(o2.getSortText()) - .compareTo(new DefaultArtifactVersion(o1.getSortText())); + String sortText1 = o1.getSortText() != null ? o1.getSortText() : o1.getLabel(); + String sortText2 = o2.getSortText() != null ? o2.getSortText() : o2.getLabel(); + return new DefaultArtifactVersion(sortText2).compareTo(new DefaultArtifactVersion(sortText1)); } }).toList(); assertEquals(orderedCompletions, completions);