New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change edc-miw-keycloak-secret in tx-data-provider #130

Open

evegufy opened this issue Oct 22, 2024 · 0 comments

Labels

Contributor

evegufy commented Oct 22, 2024

Description

The name suggests that the secret / secret alias is the client secret in centralidp Keycloak when using the Managed Identity Wallet (MIW).

https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/values.yaml#L36
https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/umbrella-1.0.0/charts/tx-data-provider/templates/post-install-vault-setup.yaml#L58

This can be confusing because, since since R2405, MIW is no longer the wallet, see note for more information.

It should be renamed because we use it now with together with the IATP mock and the SSI DIM Wallet Stub.

I suggest to rename it to edc-secret.

The text was updated successfully, but these errors were encountered:

evegufy added the enhancement label

evegufy mentioned this issue

feat: add SSI DIM Wallet Stub #125

Draft

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment