Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACE-X] 🌟🚀Access and Authentication for BPDM Lookup over EDC communication #944

Open
1 of 26 tasks
mkanal opened this issue Oct 23, 2024 · 0 comments
Open
1 of 26 tasks
Labels
Prep-R25.03 trace-x Feature/Bug for Trace-x component

Comments

@mkanal
Copy link

mkanal commented Oct 23, 2024

Overview

Explain the topic in 2 sentences

What's the benefit?

What are the Risks/Dependencies ?

  • Nothing to report

Detailed explanation

Current implementation

Proposed improvements

Feature Team

Contributor

Committer


User Story

As user
I want manufacturer name for an asset to have a clear name of the company to interact with
so that to access the bpdm API over EDC and could interact with the BPDM API in a data sov. manner.

Links

Hints / Details

  • The IRS no longer delivers BPN names within their jobResponse, which results in sentToName and createdByName attributes being null.
  • We need to either ensure that the bpdmClient works correctly to retrieve the BPN names, or manage the BPN names ourselves.
  • Investigate and decide the best approach: fixing the bpdmClient or implementing an alternative method to handle BPN names.
  • Ensure backward compatibility with the current system.

NFR

[ ] Improving performance by using caching strategy for manufacturer information in the backend instead of lookup information on each asset

Acceptance Criterias

  • Accessing new BPDM API using EDC
  • EDC is discovered over the discovering flow using BPNL to EDC lookup in EDCDiscoveryService
  • Required Changes to new BPDM API are implemented
  • New BDPM API flow is implemented
  • Adding manufacturer name to each asset, providing a BPNL
  • GIVEN asset contains valid BPNL WHEN BPDM lookup does not provide result (manufacturer name) THEN "Unknown" label is set.
  • GIVEN asset contains valid BPNL WHEN BPDM lookup error occurs, THEN "Undefined" label is set.
  • API flow and api access is covered with e2e cucumber tests
  • API flow is documented in arc42 docu
  • Create BPDM Lookup via EDC Mock to support int testing on DEV environment
  • The sentToName and createdByName attributes are correctly populated for notifications.
  • Comprehensive unit and integration tests are created to validate the solution.

Image


Test Cases

Test Case 1

Steps

  1. Do something
  2. Click something
  3. Add something

Expected Result

  1. Expectation
  2. Expectation
  3. Expectation

Architectural Relevance

The following items are ensured (answer: yes) after this issue is implemented:

Justification: (Fill this out, if at least one of the checkboxes above cannot be ticked. Contact the Architecture Management Committee to get an approval for the justification)

Additional information

  • I am aware that my request may not be developed if no developer can be found for it. I'll try to contribute a developer (bring your own developer)
@mkanal mkanal added trace-x Feature/Bug for Trace-x component Prep-R25.03 labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prep-R25.03 trace-x Feature/Bug for Trace-x component
Projects
Status: Backlog
Development

No branches or pull requests

1 participant