Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIEW_IDP to Business Admin Role #178

Open
1 task
MaximilianHauer opened this issue Aug 27, 2024 · 6 comments
Open
1 task

Add VIEW_IDP to Business Admin Role #178

MaximilianHauer opened this issue Aug 27, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@MaximilianHauer
Copy link
Contributor

MaximilianHauer commented Aug 27, 2024

Description

Currently the Business Admin does have roles to create/add users but during this process the role VIEW_IDP is needed as the frontend is checking if the company is currently undergoing a transition between two idp.
if this is the case the user creation would be blocked.
to enable the business admin to proceed the process we would need to add the role view_idp .

Acceptance Criteria

  • Business Admin does have VIEW_IDP

Additional Information

@MaximilianHauer MaximilianHauer added the enhancement New feature or request label Aug 27, 2024
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Aug 27, 2024
@Phil91 Phil91 transferred this issue from eclipse-tractusx/portal-backend Aug 27, 2024
Phil91 added a commit that referenced this issue Aug 27, 2024
@typecastcloud
Copy link
Contributor

Hi @Phil91 @MaximilianHauer,
I was just wondering if Business Admin is supposed to be able to add/remove app user for subscribed apps. I think they need modify_user_account and view_client_roles for that.

@MaximilianHauer
Copy link
Contributor Author

@typecastcloud there is no logic to add users for certain apps/services as soon as the app is subscribed via the "subscribe_apps" role the whole company can access it

@typecastcloud
Copy link
Contributor

typecastcloud commented Aug 27, 2024

@typecastcloud there is no logic to add users for certain apps/services as soon as the app is subscribed via the "subscribe_apps" role the whole company can access it

You are mistaken.

User Management -> Access Management -> Select subscribed app (here GET api/administration/user/owncompany/roles/apps endpoint is called. Requiring view_client_roles) -> Add role -> Search and Select Users -> Confirm -> Add Roles -> Confirm Selected Roles (here PUT api/administration/user/owncompany/users/{id}/apps/{id}/roles is called. Requiring modify_user_account)

I was just wondering if the Business Admin should be able to do this.

@MaximilianHauer MaximilianHauer changed the title Remove add/modify users from Business Admin role Add VIEW_IDP to Business Admin Role Aug 28, 2024
Phil91 added a commit that referenced this issue Aug 28, 2024
@MaximilianHauer
Copy link
Contributor Author

based on last discussions userstory was adjusted

@Phil91
Copy link
Member

Phil91 commented Aug 28, 2024

based on last discussions userstory was adjusted

PR was already updated as well.

Phil91 added a commit that referenced this issue Sep 16, 2024
@MaximilianHauer
Copy link
Contributor Author

waiting for resetting of INT env until it should be tested .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN REVIEW
Development

No branches or pull requests

3 participants