Gh 5121 fedx bind left join #5122
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2024 Eclipse RDF4J contributors. | ||
| * | ||
| * All rights reserved. This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Distribution License v1.0 | ||
| * which accompanies this distribution, and is available at | ||
| * http://www.eclipse.org/org/documents/edl-v10.php. | ||
| * | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| *******************************************************************************/ | ||
| package org.eclipse.rdf4j.federated.evaluation.iterator; | ||
|
|
||
| import java.util.HashSet; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.ListIterator; | ||
| import java.util.Set; | ||
|
|
||
| import org.eclipse.rdf4j.common.iteration.CloseableIteration; | ||
| import org.eclipse.rdf4j.common.iteration.LookAheadIteration; | ||
| import org.eclipse.rdf4j.query.Binding; | ||
| import org.eclipse.rdf4j.query.BindingSet; | ||
| import org.eclipse.rdf4j.query.QueryEvaluationException; | ||
| import org.eclipse.rdf4j.query.algebra.evaluation.QueryBindingSet; | ||
|
|
||
| /** | ||
| * A {@link LookAheadIteration} for processing bind left join results. | ||
| * | ||
| * Algorithm: | ||
| * | ||
| * <ul> | ||
| * <li>execute left bind join using regular bound join query</li> | ||
| * <li>process result iteration similar to {@link BoundJoinVALUESConversionIteration}</li> | ||
| * <li>remember seen set of bindings (using index) and add original bindings to those, i.e. put to result return all | ||
| * non-seen bindings directly from the input</li> | ||
| * | ||
| * | ||
| * @author Andreas Schwarte | ||
| */ | ||
| public class BindLeftJoinIteration extends LookAheadIteration<BindingSet> { | ||
|
|
||
| protected final CloseableIteration<BindingSet> iter; | ||
| protected final List<BindingSet> bindings; | ||
|
|
||
| protected Set<Integer> seenBindingIndexes = new HashSet<>(); | ||
|
There was a problem hiding this comment. Would the IntHashSet be appropriate here? |
||
| protected final ListIterator<BindingSet> bindingsIterator; | ||
|
|
||
| public BindLeftJoinIteration(CloseableIteration<BindingSet> iter, | ||
| List<BindingSet> bindings) { | ||
| this.iter = iter; | ||
| this.bindings = bindings; | ||
| this.bindingsIterator = bindings.listIterator(); | ||
| } | ||
|
|
||
| @Override | ||
| protected BindingSet getNextElement() { | ||
|
|
||
| if (iter.hasNext()) { | ||
| var bIn = iter.next(); | ||
| int bIndex = Integer.parseInt( | ||
| bIn.getBinding(BoundJoinVALUESConversionIteration.INDEX_BINDING_NAME).getValue().stringValue()); | ||
|
Comment on lines
+60
to
+61
There was a problem hiding this comment. Is the binding Value object ever a literal? So it would be possible to check if it's instanceof IntegerLiteral or something like that? |
||
| seenBindingIndexes.add(bIndex); | ||
| return convert(bIn, bIndex); | ||
| } | ||
|
|
||
| while (bindingsIterator.hasNext()) { | ||
| if (seenBindingIndexes.contains(bindingsIterator.nextIndex())) { | ||
| // the binding was already processed as part of the optional | ||
| bindingsIterator.next(); | ||
| continue; | ||
| } | ||
| return bindingsIterator.next(); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| protected void handleClose() { | ||
| iter.close(); | ||
| } | ||
|
|
||
| protected BindingSet convert(BindingSet bIn, int bIndex) throws QueryEvaluationException { | ||
| QueryBindingSet res = new QueryBindingSet(); | ||
| Iterator<Binding> bIter = bIn.iterator(); | ||
| while (bIter.hasNext()) { | ||
|
There was a problem hiding this comment. Could this be a for-each look? |
||
| Binding b = bIter.next(); | ||
| if (b.getName().equals(BoundJoinVALUESConversionIteration.INDEX_BINDING_NAME)) { | ||
| continue; | ||
| } | ||
| res.addBinding(b); | ||
| } | ||
| for (Binding bs : bindings.get(bIndex)) { | ||
| res.setBinding(bs); | ||
| } | ||
| return res; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add that this is used for OPTIONAL clauses. Is it used for anything else?