Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4999: improve UpdateWithModelBuilder to support statement removal #5008

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fkleedorfer
Copy link
Contributor

@fkleedorfer fkleedorfer commented Jun 2, 2024

GitHub issue resolved: #4999

Briefly describe the changes proposed in this PR:

The UpdateWithModelBuilder used to be just an Operation with an internal ModelBuilder that is exposed to clients. thus, one can only add statements with it, but not delete any. In practice, it turns out that sometimes, the data for one bigger update is often collected iteratively, which can lead to the need for removing some of the statements already added.

With this update, the UpdateWithModel builder allows for removal of statements, and applies additions and removals correctly when its execute() method is called.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable UpdateWithModelBuilder to delete triples, too
1 participant