GH-4999: improve UpdateWithModelBuilder to support statement removal #5008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #4999
Briefly describe the changes proposed in this PR:
The
UpdateWithModelBuilder
used to be just anOperation
with an internalModelBuilder
that is exposed to clients. thus, one can only add statements with it, but not delete any. In practice, it turns out that sometimes, the data for one bigger update is often collected iteratively, which can lead to the need for removing some of the statements already added.With this update, the
UpdateWithModel
builder allows for removal of statements, and applies additions and removals correctly when itsexecute()
method is called.PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)