Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs #5007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fkleedorfer
Copy link
Contributor

GitHub issue resolved: #4998

Briefly describe the changes proposed in this PR:

The RelationMapBuilder generates join queries on the fly, and might be in use by some users. Instead of changing it, ths PR introduces JoinQuery and friends, which offer a better solution to the same problem - they produce reusable queries transparently, allow for specifying constraints on source and target entity, and provide intuitive options for the type of join (inner/left outer/right outer).


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@fkleedorfer fkleedorfer changed the title GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs… GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs Jun 1, 2024
@fkleedorfer fkleedorfer changed the title GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs Draft: GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs Jun 3, 2024
@fkleedorfer
Copy link
Contributor Author

Sorry, had to convert this to draft. I am stumbling over the next iteration of this concept, it might take a while to update this PR.

@fkleedorfer fkleedorfer marked this pull request as draft June 3, 2024 13:53
@fkleedorfer fkleedorfer changed the title Draft: GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs GH-4998: Add JoinQuery for easy and efficient creation of joins in rdf4j spring DAOs Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve RelationMapBuilder so it creates reusable queries
1 participant