-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-4997: Enable SparqlBuilder to create VALUES clauses #5002
base: develop
Are you sure you want to change the base?
Conversation
5bbbf37
to
cd2b417
Compare
Happy to rebase that onto develop and change the target branch to develop, if needed. |
core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/constraint/Values.java
Outdated
Show resolved
Hide resolved
core/sparqlbuilder/src/main/java/org/eclipse/rdf4j/sparqlbuilder/core/query/Query.java
Show resolved
Hide resolved
Yeah, this needs to target the develop branch. Btw. Have you considered supporting VALUES inside UNION clauses? It's a common scenario for getting better performance since the scoping of the UNION means that any VALUES clauses outside the UNION clause will be evaluated after the UNION clauses. Duplicating the VALUES clause inside each branch of the UNION clause fixes the scoping issue so the VALUES clause can be used when executing the joins inside each UNION clause. |
You can add it to any GraphPattern, so you can also add it to a Union pattern |
... But we might be able to make that more explicit if you like It is generally a weakness of the sparqlbuilder package that you have to know how to produce the bits you need. The API has little 'fluency'. This here is a case in point. |
2f58b72
to
d58a6c0
Compare
GitHub issue resolved: #4997
Briefly describe the changes proposed in this PR:
Adds a builder for VALUES clauses and integrates them with GraphPattern and Select
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)