Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4950 LMDB: extensible ID scheme #4956

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kenwenzel
Copy link
Contributor

@kenwenzel kenwenzel commented Apr 17, 2024

Implement an extensible ID scheme for the LmdbStore that also allows to embed values into IDs.

GitHub issue resolved: #4950

Briefly describe the changes proposed in this PR:

Use a binary encoding for IDs that allows to represent the value type, if the value itself is embedded within the id and the embedded value itself.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad
Copy link
Contributor

The failing integration tests: It's a test that is marked as disabled, but has somehow started to run again. Not sure how that happened.

Implement an extensible ID scheme for the LmdbStore that
also allows to embed values into IDs.
@kenwenzel
Copy link
Contributor Author

@hmottestad It would be good to have this in 5.0.0 as it is a breaking change but I am not sure if I can finish the whole logic.

@hmottestad
Copy link
Contributor

Sorry. I've already published the M3 milestone build and we now have a feature freeze until the final release. The LMDB Store is experimental, so you should be able to make breaking changes for 5.1.0. Might be better too, since then users can upgrade to 5.0.0 and get all the fixes and enhancements without any major breaking changes.

@hmottestad
Copy link
Contributor

PS: The develop branch is now 5.1.0 so you can merge into the develop branch without affecting the 5.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants