-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: use jetty and/or newer verssion of Tomcat #5064
Comments
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Use Jetty 9.4, since it's already being used by other dependencies (bonus: Jetty is an Eclipse project) and uses the same Servlet API 3.1 as Tomcat. Probably supported until the end of 2025 (jetty/jetty.project#7958 @barthanssens can you explain why you are not considering to go to Jetty 11? Is it because of the Jakarta switch that is technically blocking it? |
Well, Jetty 11 (or even 12) should be the next step. Due to various other dependencies, we already have jetty 9.4 in the list of dependencies, so this should not take much effort and (if all goes well) no code changes, just a different Docker makefile that I'm preparing. (It's available on hub.docker as jetty-experimental, but I haven't tested it yet) For Jetty 11, we may need to look into the workbench / rdf4j-server (IIRC they both use Servlet API 3.1, not sure if that API works on Jetty 11 without changes). |
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
…2e tests Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
@aschwarte10 turns out Jetty 12 does indeed still support older Servlet APIs when enabling some modules :-) |
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
…2e tests Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
…2e tests Signed-off-by: Bart Hanssens <[email protected]>
Problem in jetty 12 : #5092 |
Signed-off-by: Bart Hanssens <[email protected]>
Signed-off-by: Bart Hanssens <[email protected]>
…d updated e2e tests Signed-off-by: Bart Hanssens <[email protected]>
Problem description
Tomcat 8.5 is EOL 31 March 2024 (https://tomcat.apache.org/tomcat-85-eol.html), so we either need to move to a more recent version or switch to another servlet engine for the server/workbench Docker image
Preferred solution
Use Jetty 9.4, since it's already being used by other dependencies (bonus: Jetty is an Eclipse project) and uses the same Servlet API 3.1 as Tomcat. Probably supported until the end of 2025 (jetty/jetty.project#7958)
Are you interested in contributing a solution yourself?
Yes
Alternatives you've considered
No response
Anything else?
Eventually, we'll need to move to a newer version of the servlet API
The text was updated successfully, but these errors were encountered: