Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: use jetty and/or newer verssion of Tomcat #5064

Open
barthanssens opened this issue Jun 28, 2024 · 4 comments
Open

Docker: use jetty and/or newer verssion of Tomcat #5064

barthanssens opened this issue Jun 28, 2024 · 4 comments
Assignees
Labels
docker 📶 enhancement issue is a new feature or improvement
Milestone

Comments

@barthanssens
Copy link
Contributor

Problem description

Tomcat 8.5 is EOL 31 March 2024 (https://tomcat.apache.org/tomcat-85-eol.html), so we either need to move to a more recent version or switch to another servlet engine for the server/workbench Docker image

Preferred solution

Use Jetty 9.4, since it's already being used by other dependencies (bonus: Jetty is an Eclipse project) and uses the same Servlet API 3.1 as Tomcat. Probably supported until the end of 2025 (jetty/jetty.project#7958)

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

Eventually, we'll need to move to a newer version of the servlet API

@barthanssens barthanssens added 📶 enhancement issue is a new feature or improvement docker labels Jun 28, 2024
@barthanssens barthanssens added this to the 5.1.0 milestone Jun 28, 2024
@barthanssens barthanssens self-assigned this Jun 28, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 4, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 4, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 4, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 5, 2024
@aschwarte10
Copy link
Contributor

Preferred solution

Use Jetty 9.4, since it's already being used by other dependencies (bonus: Jetty is an Eclipse project) and uses the same Servlet API 3.1 as Tomcat. Probably supported until the end of 2025 (jetty/jetty.project#7958

@barthanssens can you explain why you are not considering to go to Jetty 11? Is it because of the Jakarta switch that is technically blocking it?

@barthanssens
Copy link
Contributor Author

barthanssens commented Jul 18, 2024

Well, Jetty 11 (or even 12) should be the next step.

Due to various other dependencies, we already have jetty 9.4 in the list of dependencies, so this should not take much effort and (if all goes well) no code changes, just a different Docker makefile that I'm preparing.

(It's available on hub.docker as jetty-experimental, but I haven't tested it yet)

For Jetty 11, we may need to look into the workbench / rdf4j-server (IIRC they both use Servlet API 3.1, not sure if that API works on Jetty 11 without changes).

barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 18, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 22, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 23, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 23, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 23, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 23, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 24, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 24, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 24, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 24, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 25, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 25, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 25, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
@barthanssens
Copy link
Contributor Author

@aschwarte10 turns out Jetty 12 does indeed still support older Servlet APIs when enabling some modules :-)

barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Jul 26, 2024
@barthanssens
Copy link
Contributor Author

Problem in jetty 12 : #5092

barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 1, 2024
@barthanssens barthanssens changed the title Docker: use jetty instead of Tomcat Docker: use jetty and/or newer verssion of Tomcat Aug 1, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 1, 2024
barthanssens added a commit to Fedict/rdf4j that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker 📶 enhancement issue is a new feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants