Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Managed Version Source doesn't work for indirect version definitions #1467

Open
pbodnar opened this issue Jul 5, 2023 · 0 comments

Comments

@pbodnar
Copy link

pbodnar commented Jul 5, 2023

I think this worked before, it is reproducible e.g. on Eclipse 2023-06.

Now that eclipse/lemminx-maven/pull/298 got implemented, artifact's managed version and its source is shown once again. But it doesn't seem to display the correct source of the managed version definition when the version is defined indirectly. This is reproducible e.g. with https://github.com/apache/logging-log4j2/:

  • root parent pom.xml defines:

         <dependency>
            <groupId>org.junit</groupId>
            <artifactId>junit-bom</artifactId>
            <version>${junit-jupiter.version}</version>
            <type>pom</type>
            <scope>import</scope>
          </dependency>
    
  • log4j-api-java9\pom.xml references the parent pom and a dependency:

          <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter-engine</artifactId>
            <scope>test</scope>
          </dependency>
    
  • INCORRECT source is linked in the hover: The managed version is 5.9.2. The artifact is managed in [org.junit.jupiter:junit-jupiter-engine:5.9.2](file:///C:/...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant