-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PR previews work #185
Comments
The permissions problem can be solved. The 2 mechanisms dont work together, as GH will not deploy from the gh-pages branch anymore, thus anything committed there will not be visible. |
It might be possible to uses the deploy-pages action: https://github.com/actions/deploy-pages it has a beta feature called preview. I will test it out in a fork. |
So I tested the preview feature of the deploy-pages actions and it is still in closed alpha: actions/deploy-pages#180 This led me to this discussion page: https://github.com/orgs/community/discussions/7730 Where somebody was presenting his workaround: https://github.com/orgs/community/discussions/7730#discussioncomment-7395421 which looks pretty solid and doable:
|
Ok so I managed now to come up with a setup to deploy previews of your site. Take a look at this PR: https://github.com/netomi/langium-website/pull/6 It has a link to the preview site available at https://netomi.github.io/langium-previews/pr-previews/pr-6/ What happens:
similarly, if a PR is closed, the preview site will be removed from the langium-previews repo again. Something that I still have to test is to support PRs from outside collaborators. I think this will be possible using the pull request target trigger, but need to check it. Maybe this solution is something you are looking for? In the long term, hopefully GitHub supports deploying of previews but there is no information when this will be available, for the time being this might be a viable solution. |
Wow, cool -- thanks! So this would require to create a new repo |
yes, a separate repo is required to host the preview deployments. |
Ok the solution looks good. Please apply it to this repo. Thank you for the great support! 🙏 |
nice that it works now. I did not test the whole site for relative links, but I guess you can fix that much better than myself. The playground is really impressive imho. |
PR previews using
rossjrw/pr-preview-action
don't work yet because they are deployed to subpaths likehttps://eclipse-langium.github.io/langium-website/pr-preview/pr-181/
.In addition, there's the permissions issue mentioned in #181.
The text was updated successfully, but these errors were encountered: