Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider more stable approach when checking if local artifacts were copied to storage #39

Open
gboyvalenkov-bosch opened this issue Sep 12, 2022 · 0 comments

Comments

@gboyvalenkov-bosch
Copy link
Contributor

Currently, there is a validation in feature_test.go, in testDownloadInstall function, that does two checks in the worst case:

  1. Whether a non-copy artifact is moved to storage or not. In case the storage folder does not exist, the next check is done.
  2. Whether this artifact is copied in modules folder or not.

Since the two possible outcomes are possible, the behavior of download operation must be checked, whether it does synchronous or asynchronous moving of files. The test case should be fixed accordingly to ensure more deterministic behavior upon each execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant