streaming samples

[AlveusC]

Bug Report

Describe the Bug

Working through the samples like described in the ReadMe doenst work cause the negotiate-contract.json is faulty.
This is the error occuring

[
  {
    "message": "https://w3id.org/edc/v0.0.1/ns/policy/@type was expected to be http://www.w3.org/ns/odrl/2/Offer but it was not",
    "type": "ValidationFailure",
    "path": "https://w3id.org/edc/v0.0.1/ns/policy/@type",
    "invalidValue": [
      "https://w3id.org/edc/v0.0.1/ns/Offer"
    ]
  },
  {
    "message": "https://w3id.org/edc/v0.0.1/ns/policy/http://www.w3.org/ns/odrl/2/assigner/@id cannot be null or blank",
    "type": "ValidationFailure",
    "path": "https://w3id.org/edc/v0.0.1/ns/policy/http://www.w3.org/ns/odrl/2/assigner/@id",
    "invalidValue": null
  },
  {
    "message": "https://w3id.org/edc/v0.0.1/ns/policy/http://www.w3.org/ns/odrl/2/target/@id cannot be null or blank",
    "type": "ValidationFailure",
    "path": "https://w3id.org/edc/v0.0.1/ns/policy/http://www.w3.org/ns/odrl/2/target/@id",
    "invalidValue": null
  }
]

Expected Behavior

Working through the sample, the negotiate-contract.json should negotiate the contract about the asset

Solution

The negotiate-contract.json doesnt have the right format. The right format should look like this:

{
  "@context": {
    "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
    "odrl": "http://www.w3.org/ns/odrl/2/"
  },
  "@type": "ContractRequest",
  "counterPartyAddress": "http://localhost:18182/protocol",
  "protocol": "dataspace-protocol-http",
  "policy": {
    "@id": "Y29udHJhY3QtZGVmaW5pdGlvbg==:a2Fma2Etc3RyZWFtLWFzc2V0:ZjJmZWMyOWMtYTU4NC00ODdmLTljMWItMWZjNTc5MzNmZmVi",
    "@type": "http://www.w3.org/ns/odrl/2/Offer",
    "odrl:permission": [],
    "odrl:prohibition": [],
    "odrl:obligation": [],
    "odrl:assigner": {
      "@id": "provider"
    },
    "odrl:target": {
      "@id": "kafka-stream-asset"
    }
  }
}

[github-actions]

Thanks for your contribution 🔥 We will take a look asap 🚀

[ndr-brt]

hey, thanks for reporting, could you provide a PR to fix this issue?

[ipa-big]

I had the same issue. For me this worked:

{
  "@context":{
    "@vocab":"https://w3id.org/edc/v0.0.1/ns/"
  },
  "@type":"ContractRequest",
  "counterPartyAddress":"http://{{provider-host}}:{{provider-port-protocol}}/protocol",
  "providerId":"provider",
  "protocol":"dataspace-protocol-http",
  "policy":{
    "@context": "http://www.w3.org/ns/odrl.jsonld",
    "@id":"{{contract_offer_id}}",
    "@type":"Offer",
    "permission":[ ],
    "prohibition":[ ],
    "obligation":[ ],
    "assigner": "provider",
    "target":"stream-asset"
  }
}

Would be nice to know what is the "right" way (if this exists)

[ndr-brt]

a json-ld document has different ways to be represented, an extended way, and multiple "compact" ways, all of them are potentially "right"

[github-actions]

This issue is stale because it has been open for 14 days with no activity.