Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where the consumer uses the incorrect process id to process a provider offer #4527

Closed
jimmarino opened this issue Oct 3, 2024 · 0 comments · Fixed by #4528
Closed

Fix bug where the consumer uses the incorrect process id to process a provider offer #4527

jimmarino opened this issue Oct 3, 2024 · 0 comments · Fixed by #4528
Assignees
@jimmarino
Labels
bug_report Suspected bugs, awaiting triage

Comments

@jimmarino
Copy link
Contributor

Bug Report

ContractNegotiationProtocolServiceImpl.notifyOffered uses the provider process ID when receiving an offer sent by the provider, which is incorrect. It must use the consumer process ID to resolve the negotiation. The test is also incorrect.
@jimmarino jimmarino added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Oct 3, 2024
@jimmarino jimmarino self-assigned this Oct 3, 2024
@jimmarino jimmarino mentioned this issue Oct 3, 2024
Merged
@jimmarino jimmarino removed the triage all new issues awaiting classification label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmarino jimmarino

Labels
bug_report Suspected bugs, awaiting triage
Projects
None yet
Milestone
No milestone
1 participant
@jimmarino