Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read sensitive information from Vault: database credentials #4128

Closed
paullatzelsperger opened this issue Apr 22, 2024 · 0 comments · Fixed by #4129
Closed

Read sensitive information from Vault: database credentials #4128

paullatzelsperger opened this issue Apr 22, 2024 · 0 comments · Fixed by #4129
Assignees
Labels
core feature enhancement New feature or request triage all new issues awaiting classification

Comments

@paullatzelsperger
Copy link
Member

Feature Request

In an effort to increase security we should default to reading JDBC configuration values from the Vault. Only if values are not found in the vault should we fall back to the usual config mechanism.

This should be implemented specifically for the following properties:

  • edc.datasource.<name>.user
  • edc.datasource.<name>.password
  • edc.datasource.<name>.url

Every one of these should be read from the Vault first, and config later.

Which Areas Would Be Affected?

SQL pool implementation

Why Is the Feature Desired?

security

Solution Proposal

Attempt to read the property from the vault first, and if not found fall back to config, but issue a warning

@paullatzelsperger paullatzelsperger self-assigned this Apr 22, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Apr 22, 2024
@paullatzelsperger paullatzelsperger changed the title Read sensitive informatino from Vault: database credentials Read sensitive information from Vault: database credentials Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature enhancement New feature or request triage all new issues awaiting classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant