Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Unravel the WebSocket implementation #9

Open
ffendt opened this issue Sep 10, 2019 · 0 comments
Open

[JS] Unravel the WebSocket implementation #9

ffendt opened this issue Sep 10, 2019 · 0 comments

Comments

@ffendt
Copy link
Contributor

ffendt commented Sep 10, 2019

The WebSocket implementation of the client API currently is very difficult to read, understand and extend. When reading the code (or the tests for it), it is not possible to understand if everything works as expected or if it doesn't.

Therefore the implementation definitely requires some work (and probably a rewrite?).

Additionally to the existing provided functionality, there should also be the possibility to manually connect and disconnect the WebSocket client. Currently it will connect instantly after building it and there is no way to disconnect it.

thjaeckle pushed a commit to bosch-io/ditto-clients that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants