Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow inline editing of values #16

Open
jreineckearm opened this issue Jan 22, 2024 · 3 comments · May be fixed by #26
Open

Allow inline editing of values #16

jreineckearm opened this issue Jan 22, 2024 · 3 comments · May be fixed by #26

Comments

@jreineckearm
Copy link
Contributor

Type: Feature Request

Currently, the Peripheral Inspector allows editing of register values by an inline button/icon that appears when hovering with the mouse pointer over a tree element.
image

It would be beneficial to allow editing of values by double-clicking on an element. Like for example for the VS Code Variables view. This would make discovery of this feature easier and more intuitive.
@thegecko
Copy link
Contributor

I winder if we can raise a request on VS Code to add this capability to the basic treeview component instead of needing to rewrite it all as a webview?

@jreineckearm
Copy link
Contributor Author

I did some research and it looks like this one is closest to what this would require: microsoft/vscode#97190

@jreineckearm
Copy link
Contributor Author

jreineckearm commented Jun 4, 2024 •
edited
Loading

Another approach could be to provide a UI that can be easily wired up with a Tree Provider. This could also allow nicer (uniform) styling and open up more functionality going forward. A good candidate could be https://primereact.org/treetable/ .
This could allow:

  • Aligned register names but more importantly aligned values. Improving readability.
  • Introduction of checkboxes or dropdowns like used in other SVD based dialogs. This might be useful for other Peripheral Inspector data providers, too.
  • Search functionality.

martin-fleck-at added a commit to eclipsesource/vscode-peripheral-inspector that referenced this issue Jun 27, 2024
@martin-fleck-at @haydar-metin
Allow inline editing of values
53bb8fe 
- Propagate value updates back to the data provider and tracker
- Simplify column declaration and provide dedicated 'edit' property
-- Always render the expander on the first column
- Provide edit renderer for text value changes (more are part of eclipse-cdt-cloud#22)

Refactor:
- Convert some utility functions to React components
- Convert thenable to promises

Closes eclipse-cdt-cloud#16

Co-authored-by: Haydar Metin <[email protected]>
@martin-fleck-at martin-fleck-at linked a pull request Jun 27, 2024 that will close this issue
Draft
@martin-fleck-at martin-fleck-at mentioned this issue Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow inline editing of values eclipsesource/vscode-peripheral-inspector
2 participants
@thegecko @jreineckearm