Skip to content
This repository has been archived by the owner on Oct 13, 2020. It is now read-only.

ENH: Add javac annotation processor option for generating the 'query beans' #9

Closed
rbygrave opened this issue Sep 21, 2015 · 5 comments

Comments

@rbygrave
Copy link
Contributor

So this would be an option to use rather than the current generator using main method in src/test etc.

@icode
Copy link

icode commented Nov 12, 2015

+1 i like it 👍 🌹

@benmccann
Copy link

@rbygrave can you expand a bit more? We have a PR for adding query bean support to play-ebean, so I'm curious if this is something we could improve upon in the future

@rbygrave
Copy link
Contributor Author

rbygrave commented Dec 9, 2015

This enhancement is to provide a java annotation processor such that the
type query beans are generated at javac compile time (which is generally a
more standard approach than the current one).

So we would then have 2 options for generating the beans.

I am not sure how well it will integrate with sbt etc (javac oriented).

I might tackle it soon (in the next week) but not sure yet.

Cheers, Rob.
On 9/12/2015 6:00 PM, "Ben McCann" [email protected] wrote:

@rbygrave https://github.com/rbygrave can you expand a bit more? We
have a PR for adding query bean support to play-ebean
playframework/play-ebean#64, so I'm curious if
this is something we could improve upon in the future


Reply to this email directly or view it on GitHub
#9 (comment)
.

@rbygrave
Copy link
Contributor Author

rbygrave commented Dec 9, 2015

Note that the current generator can do 3 things:

  • generate type query beans
  • generate finders
  • modify entity beans by adding the finder to them

The javac annotation processor can't modify the entity beans and ideally we
have the option to generate the finders or not.

So there will be functional differences.
On 9/12/2015 6:53 PM, "Rob Bygrave" [email protected] wrote:

This enhancement is to provide a java annotation processor such that the
type query beans are generated at javac compile time (which is generally a
more standard approach than the current one).

So we would then have 2 options for generating the beans.

I am not sure how well it will integrate with sbt etc (javac oriented).

I might tackle it soon (in the next week) but not sure yet.

Cheers, Rob.
On 9/12/2015 6:00 PM, "Ben McCann" [email protected] wrote:

@rbygrave https://github.com/rbygrave can you expand a bit more? We
have a PR for adding query bean support to play-ebean
playframework/play-ebean#64, so I'm curious if
this is something we could improve upon in the future


Reply to this email directly or view it on GitHub
#9 (comment)
.

@rbygrave
Copy link
Contributor Author

This will be released shortly as "querybean-generator". Note that will be the preferred option for generating query beans.

Ultimately this has lead to a discussion on this artifact name "avaje-ebeanorm-typequery" and it now makes sense for this to be renamed to "avaje-ebeanorm-querybean" (and hence related to the querybean-generator etc).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants