Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited supported constraints(PATTERN) in generated contract #242

Closed
tadlakha9 opened this issue Jun 27, 2023 · 3 comments · Fixed by #247
Closed

Limited supported constraints(PATTERN) in generated contract #242

tadlakha9 opened this issue Jun 27, 2023 · 3 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@tadlakha9
Copy link

tadlakha9 commented Jun 27, 2023 •
edited
Loading

we have a pattern definition in JSON schema file, but we do not have it in generated contract file.

In the code we have support for javax.validation.constraints.Pattern but not for jakarta.validation.constraints.Pattern because of which pattern is not visible in the generated contract file.

related story for javax.validation.constraints.Pattern
@ozscheyge ozscheyge added the bug Something isn't working label Jun 28, 2023
@tadlakha9
Copy link
Author

any update

@Kieun
Copy link
Contributor

Kieun commented Sep 20, 2023

The current implementation of getting regexp from the annotation has a simple bug, which is not correctly retrieve regexp from the Constraint configuration. I could fix this issue.

@Kieun Kieun mentioned this issue Sep 22, 2023
Merged
@tadlakha9
Copy link
Author

This fix is not working and i have seen that another ticket is opened for the same issue #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to get regexp properly from the pattern constraint Kieun/restdocs-api-spec
3 participants
@Kieun @ozscheyge @tadlakha9