Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

241017 - New EEK Size Variant #2469

Open
3 tasks done
ratinsl opened this issue Oct 17, 2024 · 0 comments
Open
3 tasks done

241017 - New EEK Size Variant #2469

ratinsl opened this issue Oct 17, 2024 · 0 comments

Comments

@ratinsl
Copy link

ratinsl commented Oct 17, 2024

Description

We have a new requirement for EEK icons where the large right-facing letter has to be the same or larger type size than the item's price type size.

With this new rule, we need to add a larger EEK icon variant which is 32px tall with 24px type for the larger letter inside. The previous 24px EEK icon will remain the same and not change. The large EEK will be used for price sizes 20px and larger, while the small EEK will be used for price sizes 16px and smaller.

We don't need to handle any size switching on the skin side, I suggest we let SRP, VI, other teams to handle that scaling with price sizes on their end. They just need access to the two different variants.

Attached are specs for the size/type differences in the icon size, as well as how it will appear on larger screens with the updated 32px variant in situation on SRP/VI.

Let me know if you have any questions,
Ryan

Screenshots

10 17 24 - EEK variant update

Figma link

No response

Engineering pre-requisites

  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant