-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compliance with iOS Permissions Guidelines #1094
Comments
Given that latest versions of iOS will use a two-step strategy, and latest versions of Android are also using a two-step strategy (#990, implemented in e-mission/e-mission-data-collection#210), I think the best long-term solution may be to split the "Location Permissions" item into two separate items However, for now I will just try to meet the guidelines as quickly as possible so we are unblocked |
Yes. We used to use the standard popups, but then people would not give us the correct permissions and then complain that "the app does not work" |
@catarial is going to help verify
To do that, we need to turn off the notification permission and see if we still get the silent push notifications once an hour. So I would suggest two potential ways to check this: Option 1:
Option 2: The set of checks for validity are: So to hack, we can just change With either option, we should be able to see whether turning off notifications affects silent push notifications. So we know/can see that we get silent push when the notification permission is present; do we get them when the permission is off. |
I left the simulator running with the notification check disabled for about 2 hours and the only thing I saw in the debug logs was one instance of "Ignoring silent push notification". |
Im getting the same thing when I turn notifications back on. I need test this more. What makes this most challenging is that I have to disable push notifications to be able to install the test app on a real phone. |
I'll try option 1 with the app store version on a real phone and see what happens tomorrow. |
@catarial push notifications are not delivered to the simulator (you may see the notification about that when you start up the app). You have to try it on a physical phone. |
Our current permissions flow is deemed unacceptable. I think this is due to:
And perhaps a third point:
I am working on the changes to resolve these issues, and hopefully provide a better onboarding UX in the process.
The text was updated successfully, but these errors were encountered: