Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_orders DOES NOT WORK FOR FILLED! #205

Open
mcelia2324 opened this issue Apr 11, 2023 · 1 comment
Open

get_orders DOES NOT WORK FOR FILLED! #205

mcelia2324 opened this issue Apr 11, 2023 · 1 comment

Comments

@mcelia2324
Copy link

Can this please be fixed... FILLED is not a valid parameter to be passed but in your own code you show that it is. This was also working last year not sure why all of a sudden it has not been working this year. I submitted this ticket a while ago like january I am resubmitting the same issue for visibility. Cannot market make reliably without knowing what orders filled and its details (I know I can download the trade history via csv but it is cumbersome). PLEASE FIX
Screenshot 2023-04-10 at 8 44 26 PM

@mcelia2324
Copy link
Author

Just made a quick fix using get_order_by_id but either way, this should be an easy fix on your end and does not require the order id on the back end by the user below. This works for open orders it should also work for filled.

def get_filled_orders(self, instrument):
    """Instrument example BTC-USD"""
    api = self.connect()
    orders_response = api.private.get_orders(
        market=instrument,
        status=constants.ORDER_STATUS_FILLED,
    )

    return orders_response.data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant