Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you be willing to provide an STC playground? #1021

Open
2 of 6 tasks
sunrabbit123 opened this issue May 12, 2023 · 4 comments
Open
2 of 6 tasks

Would you be willing to provide an STC playground? #1021

sunrabbit123 opened this issue May 12, 2023 · 4 comments
Milestone
v0.3.0 wasm and n...

Comments

@sunrabbit123
Copy link
Collaborator

sunrabbit123 commented May 12, 2023 •
edited
Loading

When creating a contribution or issue, it would be nice to have a place to look up the most recent STC and write test cases more easily.
You can more easily check if an existing case is a working case or not.

Like how we use Typescript Playground to check types.

This would make it easier to submit issues without having to build and test the STC yourself.

Tasks
Beta Give feedback
  1. feat: (PoC) impl wasm support for playground. #1082
  5. Timer logging should be switched to a flag. #1081
    good first issue
@kdy1 kdy1 added this to the v0.0.1: Correctness milestone May 18, 2023
@kdy1
Copy link
Member

kdy1 commented May 18, 2023

I want to, but this is a very complex task..

@phoenix-ru
Copy link

What needs to be done to make it possible? Afaik, there is an LSP setup with VSCode. Maybe this can be done the same way as SWC playground with the nightly build of STC as a plugin?

@kdy1
Copy link
Member

kdy1 commented Jun 3, 2023

Code would be almost similar, but we should publish Wasm files

@sunrabbit123
Copy link
Collaborator Author

Do you need to do something like #300 ?
If so, do you use wasm-bindgen instead of napi-rs?

@sunrabbit123 sunrabbit123 mentioned this issue Sep 8, 2023
Merged
1 task
kdy1 pushed a commit that referenced this issue Oct 6, 2023
@AcrylicShrimp
feat: Add wasm support for playground (#1082)
bec48ce 
**Description:**

This PR implements checker behaviors for `wasm` binding. By supporting wasm, implementing playground will become very easy. I also implemented PoC of playground and it works well. I'll contribute on that when this PR is ready and merged.

Due to the constraints of wasm, there is a few APIs that should not be used. Below is the list.

- `std::time::Instant`
- `mimalloc_rust` from `swc_node_base`
- All file-system related APIs.

We dropped some code to avoid use of the APIs, and this PR contains those changes. I marked this PR as draft; we have to manage them somehow before merge it.

**Related issue:**

 - #300
 - #1021
@sunrabbit123 sunrabbit123 mentioned this issue Oct 6, 2023
Open
sunrabbit123 pushed a commit to sunrabbit123/stc that referenced this issue Oct 10, 2023
@AcrylicShrimp @sunrabbit123
feat: Add wasm support for playground (dudykr#1082)
c72935c 
**Description:**

This PR implements checker behaviors for `wasm` binding. By supporting wasm, implementing playground will become very easy. I also implemented PoC of playground and it works well. I'll contribute on that when this PR is ready and merged.

Due to the constraints of wasm, there is a few APIs that should not be used. Below is the list.

- `std::time::Instant`
- `mimalloc_rust` from `swc_node_base`
- All file-system related APIs.

We dropped some code to avoid use of the APIs, and this PR contains those changes. I marked this PR as draft; we have to manage them somehow before merge it.

**Related issue:**

 - dudykr#300
 - dudykr#1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v0.3.0 wasm and napi binding
Development

No branches or pull requests
3 participants
@phoenix-ru @kdy1 @sunrabbit123