Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messy data in profilers (New Relic, etc.) #79

Open
vladislav-yashin opened this issue Aug 27, 2020 · 1 comment
Open

Messy data in profilers (New Relic, etc.) #79

vladislav-yashin opened this issue Aug 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@vladislav-yashin
Copy link

Describe the bug

Code wrapped by effect handler is not analyzed by profilers (such as New Relic and Skylight) properly (e.g. no sql queries data when wrapped in rails controller and complete mess when wrapped with middleware)

To Reproduce

Wrap code by effect handler and introduce some profiler in the app.

Expected behavior

Code is profiled as usual.

Your environment

  • Affects my production application: YES
  • Ruby version: 2.7.1
  • OS: .Ubuntu 20.04

I'm not sure whether it's new relic/skylight problem or dry's, but hope to get some hint at least.

@vladislav-yashin vladislav-yashin added the bug Something isn't working label Aug 27, 2020
@vladislav-yashin vladislav-yashin changed the title Wrong data in profilers (New Relic, etc.) Messy data in profilers (New Relic, etc.) Aug 27, 2020
@flash-gordon flash-gordon added enhancement New feature or request and removed bug Something isn't working labels Aug 28, 2020
@flash-gordon
Copy link
Member

Hm, it's not a bug, every piece of code relying on Thread.current will need some sort of interoperability with dry-effects. I'll take a look at these libraries for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants