Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate rownames not allowed => change error notification? #36

Open
AMChalkie opened this issue Aug 1, 2018 · 2 comments
Open

duplicate rownames not allowed => change error notification? #36

AMChalkie opened this issue Aug 1, 2018 · 2 comments

Comments

@AMChalkie
Copy link

duplicate rownames not allowed caused by input with Gene ID, name not in first columns. Would be more robust to not rely on the order being correct, but find Gene ID column and put it first.

Alternatively, a better error message thown: "Gene ID expected as first column of input".

I expect a bunch of additional format checks of the input would be useful including parts to strip potentially malicious code from the input file.

@AMChalkie
Copy link
Author

Suggest using fread or similar for reading input in R. Works nicely and much more verbose in error messaging.

@drpowell
Copy link
Owner

I can't reproduce this error?
I didn't think we had a requirement for a unique gene id anywhere in degust.

We do format cleaning for the input fields to avoid malicious code from leaking into R or js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants