Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aggregate function callback #12

Open
zack-krejci opened this issue Sep 20, 2012 · 0 comments
Open

Change aggregate function callback #12

zack-krejci opened this issue Sep 20, 2012 · 0 comments

Comments

@zack-krejci
Copy link
Member

RIght now PolygonLayer.aggregate has a callback that takes a single point and a list of polygons that contain this point. This is wrong conceptually and bad for performance. Better would be to loop through each polygon and return a list of points contained in that polygon. Points would be in a LayerSelector, the polygon would not. The callback function signature should be function (Polygon, LayerSelector[Points]). Points may appear in multiple polygons by being pushed onto multiple lists by the PolygonLayer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant