Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

SymbolUploader: Do not require PersonalAccessToken when DryRun is true #142

Open
mikem8361 opened this issue Nov 2, 2019 · 0 comments
Open

SymbolUploader: Do not require PersonalAccessToken when DryRun is true #142

mikem8361 opened this issue Nov 2, 2019 · 0 comments
Assignees
@mikem8361
Labels
symbol-uploader Symbol Uploader bug or work item
Milestone
Future

Comments

@mikem8361
Copy link
Member

@tmat commented on Fri Jun 08 2018

When running the task on unofficial builds (DryRun=true) the PAT is not available.

@mikem8361 commented on Thu Jul 26 2018

I thought about this a little and one could argument that a DryRun should fail if there is no PAT. It is part of the validation.

If there is a good reason that you just want the checking from the Portable to Windows PDB conversion, then we can make the change.
@mikem8361 mikem8361 self-assigned this Nov 2, 2019
@mikem8361 mikem8361 added the symbol-uploader Symbol Uploader bug or work item label Nov 2, 2019
@mikem8361 mikem8361 added this to the 3.1 milestone Nov 2, 2019
@mikem8361 mikem8361 modified the milestones: 3.1, Future Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikem8361 mikem8361

Labels
symbol-uploader Symbol Uploader bug or work item
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@mikem8361