Config binding gen omits a needed comma in an emitted Configure overload replacement

[martincostello]

Description

Updating to .NET SDK 8.0.100-rc.2.23428.11 from 8.0.100-rc.2.23427.4 introduces compilation errors in the configuration binding source generator:

Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(59,227): error CS1003: Syntax error, ',' expected [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]
Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(58,35): error CS0246: The type or namespace name 'IOptionsChangeTokenSource<>' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]
Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(58,76): error CS0246: The type or namespace name 'ConfigurationChangeTokenSource<>' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]

/cc @layomia

Reproduction Steps

1. Clone martincostello/costellobot@09ae9ea.
2. Run build.ps1 in the root of the repository.

Expected behavior

The application compiles.

Actual behavior

The application fails to compile with CS1003 and CS0246 errors.

Regression?

Yes compared to recent preview builds.

Known Workarounds

None.

Configuration

.NET SDK 8.0.100-rc.2.23428.11

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Updating to .NET SDK 8.0.100-rc.2.23428.11 from 8.0.100-rc.2.23427.4 introduces compilation errors in the configuration binding source generator:

Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(59,227): error CS1003: Syntax error, ',' expected [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]
Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(58,35): error CS0246: The type or namespace name 'IOptionsChangeTokenSource<>' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]
Error: /home/runner/work/costellobot/costellobot/src/Costellobot/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(58,76): error CS0246: The type or namespace name 'ConfigurationChangeTokenSource<>' could not be found (are you missing a using directive or an assembly reference?) [/home/runner/work/costellobot/costellobot/src/Costellobot/Costellobot.csproj]

/cc @layomia

Reproduction Steps

1. Clone martincostello/costellobot@09ae9ea.
2. Run build.ps1 in the root of the repository.

Expected behavior

The application compiles.

Actual behavior

The application fails to compile with CS1003 and CS0246 errors.

Regression?

Yes compared to recent preview builds.

Known Workarounds

None.

Configuration

.NET SDK 8.0.100-rc.2.23428.11

Other information

No response

Author:	martincostello
Assignees:	-
Labels:	untriaged, area-Extensions-Configuration
Milestone:	-

[ShreyasJejurkar]

cc @layomia

[stephentoub]

Simple repro:

using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;

IServiceCollection services = null!;
IConfiguration configuration = null!;
services.Configure<MyOptions>(configuration.GetSection("repro"));

class MyOptions { }

[layomia]

Thanks folks. I fixed this in #91180, which introduced build coverage for all the options-binding-extension methods to prevent regressions. We're planning to port it to RC-2.

@martincostello, please try the fix when you get a chance.

[martincostello]

Sure, will report back when the SDK version flowing into my automation includes the fix.

[layomia]

I ran into a different issue unrelated to this one when testing the fix on the costellobot project martincostello/costellobot@09ae9ea.

I'll share details shortly & will likely create a separate issue.

[layomia]

I ran into a different issue unrelated to this one when testing the fix on the costellobot project martincostello/costellobot@09ae9ea.

I'll share details shortly & will likely create a separate issue.

Scratch this, all's well. I verified that the fix works in your project. Pls let us know if you still face issues here & I'll reopen the issue.

[martincostello]

@layomia As well as spreading to an additional repository with the 8.0.100-rc.2.23429.6 SDK today, I've got a new problem in a third repository:

Error: D:\a\apple-fitness-workout-mapper\apple-fitness-workout-mapper\src\AppleFitnessWorkoutMapper\Microsoft.Extensions.Configuration.Binder.SourceGeneration\Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator\BindingExtensions.g.cs(36,90): error CS9143: The given line is '20' characters long, which is fewer than the provided character number '22'. [D:\a\apple-fitness-workout-mapper\apple-fitness-workout-mapper\src\AppleFitnessWorkoutMapper\AppleFitnessWorkoutMapper.csproj]

Is this something that should already have been fixed and I just need to wait to flow into the installer/SDK, or is this a new problem?

[layomia]

@martincostello thanks. That issue is fixed with #91107.

#90851 describes it more, and this LOC is a sample test case. Workaround would be to move the .Configure call to the same LOC as builder.Services, but that won't be needed when the fix flows through.