TestResourceManagerIsSafeForConcurrentAccessAndEnumeration fails intermittently in CI #80277
Labels
area-System.Resources
blocking-clean-ci
Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Known Build Error
Use this to report build issues in the .NET Helix tab
Comments
jkotas
added
blocking-clean-ci
|
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-resources Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=124218 Error MessageFill the error message using known issues guidance. {
"ErrorMessage": "TestResourceManagerIsSafeForConcurrentAccessAndEnumeration",
"BuildRetry": false
}
|
madelson
added a commit
to madelson/runtime
that referenced
this issue
Jan 7, 2023
…numeration This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix dotnet#80277
This was referenced Jan 7, 2023
Closed
ghost
added
the
in-pr
|
It looks like this is only for the version of this test in System.Resources.Extensions and that the failure is a timeout. I recall getting feedback to raise the timeout on the original PR, but it looks like I forgot to do it for this version of the test :-/. Filed a PR to make the two timeouts the same; hopefully this is sufficient to address. |
stephentoub
pushed a commit
that referenced
this issue
Jan 7, 2023
…numeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277
ghost
removed
in-pr
2 tasks
buyaa-n
pushed a commit
that referenced
this issue
Jan 31, 2023
…numeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277
buyaa-n
pushed a commit
that referenced
this issue
Jan 31, 2023
…numeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277
2 tasks
ghost
locked as resolved and limited conversation to collaborators
carlossanlop
pushed a commit
that referenced
this issue
Feb 10, 2023
…numeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277
carlossanlop
pushed a commit
that referenced
this issue
Mar 10, 2023
…er. (#81283) * Fix thread-safety issues with enumerating ResourceManager. Concurrently enumerating a ResourceManager while also calling GetString() and similar methods was prone to both transient errors and deadlock. The transient errors were caused by RuntimeResourceSet calling internal methods on ResourceReader that did not properly lock. Now, all exposed methods on the Reader are thread-safe. The deadlock was called by inconsistent lock ordering between ResourceReader.ResourceEnumerator and RuntimeResourceSet which both lock on the RuntimeResourceSet's cache and on the ResourceReader itself. Now, the enumerator does not need to take both locks at the same time. Fix #74052 Fix #74868 * Remove trailing whitespace * Address feedback from #75054 * Add comment in response to #75054 (comment) * Implement feedback from #75054 * Increase timeout for TestResourceManagerIsSafeForConcurrentAccessAndEnumeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277 --------- Co-authored-by: Michael Adelson <[email protected]> Co-authored-by: madelson <[email protected]> Co-authored-by: Buyaa Namnan <[email protected]>
carlossanlop
added a commit
that referenced
this issue
Mar 10, 2023
…er. (#81281) * Fix thread-safety issues with enumerating ResourceManager. Concurrently enumerating a ResourceManager while also calling GetString() and similar methods was prone to both transient errors and deadlock. The transient errors were caused by RuntimeResourceSet calling internal methods on ResourceReader that did not properly lock. Now, all exposed methods on the Reader are thread-safe. The deadlock was called by inconsistent lock ordering between ResourceReader.ResourceEnumerator and RuntimeResourceSet which both lock on the RuntimeResourceSet's cache and on the ResourceReader itself. Now, the enumerator does not need to take both locks at the same time. Fix #74052 Fix #74868 * Remove trailing whitespace * Address feedback from #75054 * Add comment in response to #75054 (comment) * Implement feedback from #75054 * Increase timeout for TestResourceManagerIsSafeForConcurrentAccessAndEnumeration (#80330) This raises the timeout to 30s, the same as what we have for the equivalent ResourceManager test (https://github.com/dotnet/runtime/blob/15fcb990fe17348ab6ddde0939200b900169920b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs#L255). fix #80277 --------- Co-authored-by: Michael Adelson <[email protected]> Co-authored-by: madelson <[email protected]> Co-authored-by: Carlos Sanchez <[email protected]> Co-authored-by: Buyaa Namnan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=124218
Build error leg or test failing: System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration
Pull request: #79970
Error Message
Fill the error message using known issues guidance.
{ "ErrorMessage": "TestResourceManagerIsSafeForConcurrentAccessAndEnumeration", "BuildRetry": false }Report
Summary
The text was updated successfully, but these errors were encountered: