Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License metadata on windows runtime nuget packages is wrong #108905

Open
js6pak opened this issue Oct 15, 2024 · 4 comments
Open

License metadata on windows runtime nuget packages is wrong #108905

js6pak opened this issue Oct 15, 2024 · 4 comments

Comments

@js6pak
Copy link

js6pak commented Oct 15, 2024

According to the LICENSE.TXT inside dotnet-sdk-8.0.403-win-x64.zip/dotnet-runtime-8.0.10-win-x64.zip the license of those binaries is the .NET Library License.
But the license fields on https://www.nuget.org/packages/Microsoft.NETCore.App.Runtime.win-x64/8.0.10 and https://www.nuget.org/packages/Microsoft.WindowsDesktop.App.Runtime.win-x64/8.0.10 say MIT even though they contain the offending binaries: runtimes/win-x64/native/Microsoft.DiaSymReader.Native.amd64.dll, runtimes/win-x64/native/PresentationNative_cor3.dll etc.

Also, there is the question of whether the license is even .NET Library License if it contains files like runtimes/win-x64/native/D3DCompiler_47_cor3.dll and runtimes/win-x64/native/vcruntime140_cor3.dll which according to https://github.com/dotnet/core/blob/main/license-information-windows.md are licensed under Windows SDK License and Microsoft Visual C++ Runtime Software License, respectively.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 15, 2024
@vcsjones vcsjones added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 15, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Oct 16, 2024

cc @richlander

@richlander
Copy link
Member

Thanks for the report! You are correct. That doesn't seem right. We'll get this fixed in main and then backport.

I'll talk to some folks.

@jeffhandley jeffhandley added blocking-release and removed untriaged New issue has not been triaged by the area owner labels Oct 20, 2024
@jeffhandley jeffhandley added this to the 9.0.0 milestone Oct 20, 2024
@jeffhandley
Copy link
Member

cc @dotnet/area-infrastructure-libraries for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants