-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from 7 repositories #108636
base: main
Are you sure you want to change the base?
[main] Update dependencies from 7 repositories #108636
Conversation
Microsoft.DotNet.ApiCompat.Task From Version 10.0.100-alpha.1.24480.5 -> To Version 10.0.100-alpha.1.24507.16
…nals build 20241007.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24502.3 -> To Version 10.0.0-alpha.1.24507.2
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24503.1 -> To Version 10.0.0-alpha.1.24507.2
…ld 20241007.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24480.2 -> To Version 10.0.0-beta.24507.1
…ild 20241007.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 10.0.0-alpha.0.24480.1 -> To Version 10.0.0-alpha.0.24507.1
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24510.1
…ld 20241010.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24507.1 -> To Version 10.0.0-beta.24510.1
…ild 20241010.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 10.0.0-alpha.0.24507.1 -> To Version 10.0.0-alpha.0.24510.1
…10.1 Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.24480.1 -> To Version 0.11.5-alpha.24510.1
…nals build 20241011.4 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24511.4
Microsoft.DotNet.ApiCompat.Task From Version 10.0.100-alpha.1.24507.16 -> To Version 10.0.100-alpha.1.24510.13
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24510.1 -> To Version 10.0.0-alpha.1.24514.3 Dependency coherency updates runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools From Version 19.1.0-alpha.1.24501.1 -> To Version 19.1.0-alpha.1.24503.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
…ld 20241014.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24510.1 -> To Version 10.0.0-beta.24514.1
…ild 20241014.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 10.0.0-alpha.0.24510.1 -> To Version 10.0.0-alpha.0.24514.1
…14.1 Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.24510.1 -> To Version 0.11.5-alpha.24514.1
…nals build 20241014.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24511.4 -> To Version 10.0.0-alpha.1.24514.2
…15.1 Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.24514.1 -> To Version 0.11.5-alpha.24515.1
…nals build 20241015.3 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24514.2 -> To Version 10.0.0-alpha.1.24515.3
…nals build 20241016.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24515.3 -> To Version 10.0.0-alpha.1.24516.1
…5f2c-4ca0-9919-7d14fa548ee9
…1017.1 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 10.0.0-alpha.1.24511.14 -> To Version 10.0.0-alpha.1.24517.1
This is failing with a "new prebuilt", |
eng/Version.Details.xml
Outdated
<Uri>https://github.com/dotnet/sdk</Uri> | ||
<Sha>9de571282093d76401a3f457a8e9f4427e088778</Sha> | ||
<Sha>1f220e48e5bc666e992b24f118a17e01ca316819</Sha> | ||
</Dependency> | ||
<!-- Intermediate is necessary for source build. --> | ||
<Dependency Name="Microsoft.SourceBuild.Intermediate.sdk" Version="10.0.100-alpha.1.24480.5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package version also needs to get updated. It needs to be in sync with and other dotnet/sdk dependencies in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to manually update the Sha too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the ApiCompat.Task version and sha upgrade are the ones that need to be downgraded as for whatever reason, there is not a newer Microsoft.SourceBuild.Intermediate.sdk
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will downgrade those and then strip NO-MERGE.
Update Microsoft.SourceBuild.Intermediate.sdk version to match other dotnet/sdk dependencies
Update the SHA too
Downgrade ApiCompat.Task instead.
Downgrade ApiCompatTaskVersion as well
The Pri0 Runtime Tests Run windows JIT test failures look real, but I'm not sure what could have caused them and why it only seems to be the windows lanes. |
Agreed... It seems most of the runtime tests are failing with something like:
|
It appears to happen when ilasm flows (I reproduced it locally), but the "corrupt" DLL files are not corrupt according to peverify, ilverify, ilspy, or ildasm. It seems like it might be a latent bug in the IL verifier in coreclr (that is only enabled in checked builds). I'm not sure why ilasm's behavior changed though, I've verified manually that none of the new behavior I added should be engaged (it's off by default). |
Should I undo the flowing of IL SDK and ilasm for now? It's beyond me how it's broken, but it would unblock flow for now. I think the verifier is what needs to be fixed, since nothing seems to be wrong with the generated DLLs. |
This pull request updates the following dependencies
From https://github.com/dotnet/sdk
From https://github.com/dotnet/source-build-externals
From https://github.com/dotnet/icu
From https://github.com/dotnet/runtime-assets
From https://github.com/dotnet/hotreload-utils
From https://github.com/dotnet/cecil
From https://github.com/dotnet/runtime
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format