Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: Regressions in SIMD.ConsoleMandel and System.Numerics.Tests.Perf_BigInteger #105329

Open
performanceautofiler bot opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue ViperUbuntu
Baseline 19f03850cafa68cf396ecadf86e19df714b0a280
Compare 223249fa87a5f84cc67e83699f64ca80180a1862
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in SIMD.ConsoleMandel

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
649.42 ms 693.68 ms 1.07 0.00 True
656.66 ms 692.76 ms 1.05 0.00 True

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'SIMD.ConsoleMandel*'

SIMD.ConsoleMandel.ScalarDoubleSinglethreadADT

ETL Files

Histogram

JIT Disasms

SIMD.ConsoleMandel.ScalarFloatSinglethreadADT

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue ViperUbuntu
Baseline 19f03850cafa68cf396ecadf86e19df714b0a280
Compare 223249fa87a5f84cc67e83699f64ca80180a1862
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Tests.Perf_PriorityQueue<Int32, Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
16.57 μs 18.02 μs 1.09 0.08 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Perf_PriorityQueue&lt;Int32, Int32&gt;*'

System.Collections.Tests.Perf_PriorityQueue<Int32, Int32>.HeapSort(Size: 1000)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue ViperUbuntu
Baseline 19f03850cafa68cf396ecadf86e19df714b0a280
Compare 223249fa87a5f84cc67e83699f64ca80180a1862
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Numerics.Tests.Perf_BigInteger

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
4.37 μs 4.68 μs 1.07 0.00 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_BigInteger*'

System.Numerics.Tests.Perf_BigInteger.GreatestCommonDivisor(arguments: 1024,1024 bits)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Jul 23, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Jul 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 23, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Jul 23, 2024

Potentially caused by: #104752, improvements listed in PR. @AndyAyersMS

@LoopedBard3 LoopedBard3 changed the title [Perf] Linux/x64: 4 Regressions on 7/17/2024 10:10:17 PM [Perf] Linux/x64: Regressions in SIMD.ConsoleMandel and System.Numerics.Tests.Perf_BigInteger Jul 23, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Jul 23, 2024

Related Regressions:
Windows/x64: dotnet/perf-autofiling-issues#38719
Linux/x64: dotnet/perf-autofiling-issues#38695

@AndyAyersMS AndyAyersMS self-assigned this Jul 23, 2024
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Jul 23, 2024
@AndyAyersMS AndyAyersMS added this to the 9.0.0 milestone Jul 23, 2024
@AndyAyersMS
Copy link
Member

Will see if this is fixable in 9.0...

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS AndyAyersMS added Priority:2 Work that is important, but not critical for the release tenet-performance-benchmarks Issue from performance benchmark and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 25, 2024
@AndyAyersMS
Copy link
Member

These all seem to be viper (zen4) specific, and linux specific as well. Since other arch/os combinations are ok, I'm going to defer this one.

@AndyAyersMS AndyAyersMS modified the milestones: 9.0.0, 10.0.0 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

3 participants