Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metadata] Move MonoClass:inlinearray_value out of MonoClass #103913

Open
lambdageek opened this issue Jun 24, 2024 · 3 comments
Open

[metadata] Move MonoClass:inlinearray_value out of MonoClass #103913

lambdageek opened this issue Jun 24, 2024 · 3 comments
Labels
area-VM-meta-mono enhancement Product code improvement that does NOT require public API changes/additions good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
10.0.0

Comments

@lambdageek
Copy link
Member

inline arrays are quite infrequent. We have the is_inlinearray bit on MonoClass for fast checks, but inlinearray_value doesn't really need to be on every single MonoClass. We should move it to MonoClass:infrequent_data, or at least to MonoClassDef (since generic instances can't change a custom attribute value).
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 24, 2024
@lambdageek lambdageek added area-VM-meta-mono and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 24, 2024
@lambdageek lambdageek added this to the 9.0.0 milestone Jun 24, 2024
@lambdageek lambdageek added help wanted [up-for-grabs] Good issue for external contributors good first issue Issue should be easy to implement, good for first-time contributors enhancement Product code improvement that does NOT require public API changes/additions labels Jun 24, 2024
@steveisok steveisok modified the milestones: 9.0.0, 10.0.0 Jul 24, 2024
@syfFerdinand

This comment has been minimized.

Sign in to view
@syfFerdinand
Copy link

Hello everyone,

I just saw that @DevPio expressed interest in working on this issue 5 hours ago. If needed, I'm also available and motivated to contribute. We can even collaborate if necessary.

Thank you very much!

@lambdageek
Copy link
Member Author

@DevPio @syfFerdinand we generalliy don't assign issues to community contributors, but if you want to work on it, please open a PR when you have something. If you'd like to discuss the issue, the .NET Discord server https://aka.ms/dotnet-discord has a #monovm channel for Mono-related chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-VM-meta-mono enhancement Product code improvement that does NOT require public API changes/additions good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
3 participants
@steveisok @lambdageek @syfFerdinand